From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753012AbbJMN0G (ORCPT ); Tue, 13 Oct 2015 09:26:06 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:37748 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752356AbbJMN0D (ORCPT ); Tue, 13 Oct 2015 09:26:03 -0400 X-AuditID: cbfee690-f794e6d0000014de-d0-561d06692c9b Message-id: <561D0641.5060205@samsung.com> Date: Tue, 13 Oct 2015 18:55:21 +0530 From: Pankaj Dubey User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: kgene@kernel.org, heiko@sntech.de, thomas.ab@samsung.com, p.fedin@samsung.com Subject: Re: [PATCH v2 0/7] Add support for Exynos SROM Controller driver References: <1440403348-8974-1-git-send-email-pankaj.dubey@samsung.com> <55DBD063.5040703@samsung.com> In-reply-to: <55DBD063.5040703@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCIsWRmVeSWpSXmKPExsWyRsSkSjeTTTbM4PROPov/j16zWrx+YWjR //g1s8Wmx9dYLS7vmsNmMeP8PiaLV5dWsVl0LGN04PDYtKqTzWPzknqPvi2rGD22X5vH7PF5 k1wAaxSXTUpqTmZZapG+XQJXxstDqQXPpSrOTJ3P3MB4VriLkZNDQsBE4v+XL6wQtpjEhXvr 2boYuTiEBFYwSqx4/I+li5EDrKjzSzREfBajxKJp85kgnO+MEvP/zWEB6eYV0JL4t+oHWAOL gKrEhYm1IGE2AV2JJ+/nMoPYogIREm8vn2SCKBeU+DH5HgvIHBGBOYwSXdMXgCWYBYIlru1p BJspLOApMePJO7BmIYEMibUnf7CD2JwC2hKLF06EqreVWPB+HQuELS+xec1bZpChEgLX2CVm bekGa2AREJD4NvkQ1DeyEpsOMEN8LClxcMUNlgmMYrOQ3DQLydhZSMYuYGRexSiaWpBcUJyU XmSiV5yYW1yal66XnJ+7iREYeaf/PZuwg/HeAetDjAIcjEo8vC8iZcKEWBPLiitzDzGaAl0x kVlKNDkfGN95JfGGxmZGFqYmpsZG5pZmSuK8r6V+BgsJpCeWpGanphakFsUXleakFh9iZOLg lGpgdE7hnWe4Vb5KRG/uL4eqebF8rxPnv7m3+7HG1bK6/xP7H2ceLisU4Hh9RjB9GtuD5XsO ZD32Z3QqZ5m+MXyvwGkdkzA1YfHgtlkcPy12L7tfdqxZe+Pta+/mTZSR2qUfolp6IDnL/OtX jtO+hb6La3L36D7vfNVqNNvgAXfdmfipbow9G/ZFKrEUZyQaajEXFScCAOVZk5C3AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrIIsWRmVeSWpSXmKPExsVy+t9jQd1MNtkwgyPT2Sz+P3rNavH6haFF /+PXzBabHl9jtbi8aw6bxYzz+5gsXl1axWbRsYzRgcNj06pONo/NS+o9+rasYvTYfm0es8fn TXIBrFENjDYZqYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5 QJcoKZQl5pQChQISi4uV9O0wTQgNcdO1gGmM0PUNCYLrMTJAAwlrGDNeHkoteC5VcWbqfOYG xrPCXYwcHBICJhKdX6K7GDmBTDGJC/fWs3UxcnEICcxilFg0bT4ThPOdUWL+vzksIFW8AloS /1b9YAFpZhFQlbgwsRYkzCagK/Hk/VxmEFtUIELi7eWTTBDlghI/Jt9jAZkjIjCHUaJr+gKw BLNAsMS1PY1gM4UFPCVmPHkH1iwkkCGx9uQPdhCbU0BbYvHCiVD1thIL3q9jgbDlJTavecs8 gRHoTIQds5CUzUJStoCReRWjRGpBckFxUnquYV5quV5xYm5xaV66XnJ+7iZGcHQ/k9rBeHCX +yFGAQ5GJR7eF5EyYUKsiWXFlbmHGCU4mJVEeJNagEK8KYmVValF+fFFpTmpxYcYTYGBMJFZ SjQ5H5h48kriDY1NzE2NTS1NLEzMLJXEeW8cYggTEkhPLEnNTk0tSC2C6WPi4JRqYDz1uULk 7v0DK3XKnki03WJ/W334tkLS1BPb29Vf/4ldNP3+tXsVJsyu78Wibj3Zl/tT2tfJKUxj40ln 7d+T18hp8Z18mJazvH/HhMwum828xq3H/il8ECpcNeOVhQTHB/bI08v2a2VXcvzou3k0L7K/ jOf5572zflrfmXj+eL5Cxr0fe6PPi+QosRRnJBpqMRcVJwIAONLMOAQDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Tuesday 25 August 2015 07:48 AM, Krzysztof Kozlowski wrote: > On 24.08.2015 17:02, Pankaj Dubey wrote: >> This patch set adds support for Exynos SROM controller DT based driver. >> Currently SROM register sets are used only during S2R, so driver >> basically added for taking care of S2R. It will help us in removing >> static mapping from exynos.c and other extra code handline during S2R. >> >> This patch set also updated exynos4 and exynos5 dtsi files for with device >> node for srom, and added binding documentation for the same. >> >> First two patches are some minor cleanup in mach-exynos. >> >> Patchset v1 was posted here[1] >> [1]: https://lkml.org/lkml/2015/4/29/98 >> >> Changes since v1: >> - Rebased to latest kgene tree. >> - Addressed review comments from Krzysztof Kozlowski. >> - Add two new patches for minor cleanup in exynos.c and map.h >> >> Pankaj Dubey (7): >> ARM: EXYNOS: remove unused static mapping of CMU for exynos5 >> ARM: EXYNOS: code cleanup in map.h >> drivers: soc: add support for exynos SROM driver >> ARM: EXYNOS: Remove SROM related register settings from mach-exynos >> ARM: dts: add SROM device node for exynos4 >> ARM: dts: add SROM device node for exynos5 >> Documentation: dt-bindings: add exynos-srom binding information > > One more thing: please update the existing Exynos entry in maintainers > so it would cover drivers/soc/samsung. > Thanks for review, and sorry for late reply. I have updated v3 version of this patch series addressing most of your review comments. Please do let me know if still it has any concern. Regarding Pavel's comment of handling any other external peripheral which can be hooked into srom can be handled as feature addition on top of this basic driver based on requirement. Thanks, Pankaj Dubey > Best regards, > Krzysztof > >> >> .../bindings/arm/samsung/exynos-srom.txt | 12 ++ >> arch/arm/boot/dts/exynos4.dtsi | 5 + >> arch/arm/boot/dts/exynos5.dtsi | 5 + >> arch/arm/mach-exynos/Kconfig | 2 + >> arch/arm/mach-exynos/common.h | 2 - >> arch/arm/mach-exynos/exynos.c | 22 ---- >> arch/arm/mach-exynos/include/mach/map.h | 8 -- >> arch/arm/mach-exynos/regs-srom.h | 53 -------- >> arch/arm/mach-exynos/suspend.c | 20 +-- >> arch/arm/plat-samsung/include/plat/map-s5p.h | 1 - >> drivers/soc/Kconfig | 1 + >> drivers/soc/Makefile | 1 + >> drivers/soc/samsung/Kconfig | 13 ++ >> drivers/soc/samsung/Makefile | 1 + >> drivers/soc/samsung/exynos-srom.c | 143 +++++++++++++++++++++ >> drivers/soc/samsung/exynos-srom.h | 51 ++++++++ >> 16 files changed, 236 insertions(+), 104 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/arm/samsung/exynos-srom.txt >> delete mode 100644 arch/arm/mach-exynos/regs-srom.h >> create mode 100644 drivers/soc/samsung/Kconfig >> create mode 100644 drivers/soc/samsung/Makefile >> create mode 100644 drivers/soc/samsung/exynos-srom.c >> create mode 100644 drivers/soc/samsung/exynos-srom.h >> > >