From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932438AbbJMNoV (ORCPT ); Tue, 13 Oct 2015 09:44:21 -0400 Received: from smtp-out-102.synserver.de ([212.40.185.102]:1600 "EHLO smtp-out-100.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932114AbbJMNoT (ORCPT ); Tue, 13 Oct 2015 09:44:19 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 22392 Message-ID: <561D0AA9.5080702@metafoo.de> Date: Tue, 13 Oct 2015 15:44:09 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Koro Chen , broonie@kernel.org, perex@perex.cz, tiwai@suse.de, lgirdwood@gmail.com CC: srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, p.zabel@pengutronix.de Subject: Re: [RFC PATCH] ASoC: Modify check condition of multiple bindings of components References: <1444743477-48819-1-git-send-email-koro.chen@mediatek.com> In-Reply-To: <1444743477-48819-1-git-send-email-koro.chen@mediatek.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2015 03:37 PM, Koro Chen wrote: > The patch "ASoC: Prevent components from being bound to multiple cards" > adds check to prevent multiple cards from using the same component. > However, snd_soc_register_platform() or snd_soc_register_codec() will > also create components, and sharing the same platform by multiple cards > is then refused. This happens with a platform having multiple > independent DAIs that share the same DMA controller. > > Relax the condition by checking component->registered_as_component, > which is only true in case of snd_soc_register_component() and > will be false for components created by snd_soc_register_platform() > or snd_soc_register_codec(). Binding a component to multiple cards results in internal data structure corruption, regardless of whether it is a raw component, CODEC or platform, which is why the check was added. So the proposed change wont work. > > Signed-off-by: Koro Chen > --- > sound/soc/soc-core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c > index 42575b0..eca169a 100644 > --- a/sound/soc/soc-core.c > +++ b/sound/soc/soc-core.c > @@ -1106,7 +1106,8 @@ static int soc_probe_component(struct snd_soc_card *card, > return 0; > > if (component->card) { > - if (component->card != card) { > + if (component->card != card && > + component->registered_as_component) { > dev_err(component->dev, > "Trying to bind component to card \"%s\" but is already bound to card \"%s\"\n", > card->name, component->card->name); >