From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932510AbbJMOCQ (ORCPT ); Tue, 13 Oct 2015 10:02:16 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:45175 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932289AbbJMOCO (ORCPT ); Tue, 13 Oct 2015 10:02:14 -0400 Subject: Re: [RFC PATCH] phy: exynos-ufs: exynos_ufs_phy_calibrate() can be static To: Alim Akhtar , kbuild test robot References: <201510011920.tppZbk0e%fengguang.wu@intel.com> <20151001110430.GA12682@athens> <561CED52.9010806@samsung.com> CC: , , , , , , , From: Kishon Vijay Abraham I Message-ID: <561D0EDD.80804@ti.com> Date: Tue, 13 Oct 2015 19:32:05 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <561CED52.9010806@samsung.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday 13 October 2015 05:08 PM, Alim Akhtar wrote: > HI > How I am support to handle this patch? Should I just fix these warnings > in my patch or I just add this as a separate patch on the top of the > series? This series has not been merged yet. So you can fix this patch. Thanks Kishon > > > On 10/01/2015 04:34 PM, kbuild test robot wrote: >> >> Signed-off-by: Fengguang Wu >> --- >> phy-exynos-ufs.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/phy/phy-exynos-ufs.c b/drivers/phy/phy-exynos-ufs.c >> index 343fcaf..835ee78 100644 >> --- a/drivers/phy/phy-exynos-ufs.c >> +++ b/drivers/phy/phy-exynos-ufs.c >> @@ -66,7 +66,7 @@ static bool match_cfg_to_pwr_mode(u8 desc, u8 >> required_pwr) >> return false; >> } >> >> -int exynos_ufs_phy_calibrate(struct phy *phy, enum phy_cfg_tag tag, >> u8 pwr) >> +static int exynos_ufs_phy_calibrate(struct phy *phy, enum phy_cfg_tag >> tag, u8 pwr) >> { >> struct exynos_ufs_phy *ufs_phy = get_exynos_ufs_phy(phy); >> struct exynos_ufs_phy_cfg **cfgs = ufs_phy->cfg; >> @@ -93,14 +93,14 @@ out: >> return 0; >> } >> >> -void exynos_ufs_phy_set_lane_cnt(struct phy *phy, u8 lane_cnt) >> +static void exynos_ufs_phy_set_lane_cnt(struct phy *phy, u8 lane_cnt) >> { >> struct exynos_ufs_phy *ufs_phy = get_exynos_ufs_phy(phy); >> >> ufs_phy->lane_cnt = lane_cnt; >> } >> >> -int exynos_ufs_phy_wait_for_lock_acq(struct phy *phy) >> +static int exynos_ufs_phy_wait_for_lock_acq(struct phy *phy) >> { >> struct exynos_ufs_phy *ufs_phy = get_exynos_ufs_phy(phy); >> const unsigned int timeout_us = 100000; >>