From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932505AbbJMO0P (ORCPT ); Tue, 13 Oct 2015 10:26:15 -0400 Received: from foss.arm.com ([217.140.101.70]:53353 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753134AbbJMO0L (ORCPT ); Tue, 13 Oct 2015 10:26:11 -0400 Subject: Re: [PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean To: Rob Herring References: <1444743164-17735-1-git-send-email-sudeep.holla@arm.com> <1444743164-17735-2-git-send-email-sudeep.holla@arm.com> Cc: Sudeep Holla , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Kevin Hilman , Olof Johansson , Arnd Bergmann , Heiko Stuebner , linux-rockchip@lists.infradead.org, Viresh Kumar , spear-devel From: Sudeep Holla Message-ID: <561D147F.6090907@arm.com> Date: Tue, 13 Oct 2015 15:26:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/10/15 15:07, Rob Herring wrote: > On Tue, Oct 13, 2015 at 8:32 AM, Sudeep Holla wrote: >> Keyboard driver for GPIO buttons(gpio-keys) checks for the legacy >> "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup >> source. >> >> Few dts files assign value "1" to gpio-key,wakeup and in one instance a >> value "0" is assigned probably assuming it won't be enabled as a wakeup >> source. Since the presence of the boolean property indicates it is >> enabled, value of "0" have no value. >> >> This patch removes the property where value "0" is assigned and removes >> the value "1" in most of the other cases. > > Why don't you just change everything to wakeup-source. > Agreed, I wanted to do that but was not sure if that's acceptable. I will update it, now I know that you are fine with it. I also plan to find all the variety of bindings we have and fix them retaining only those which are handled in the current kernel code as legacy support. -- Regards, Sudeep