From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932174AbbJMO67 (ORCPT ); Tue, 13 Oct 2015 10:58:59 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:33404 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752300AbbJMO66 (ORCPT ); Tue, 13 Oct 2015 10:58:58 -0400 Subject: Re: [PATCH 1/3] staging: rtl8188eu: 5 GHz channel groups removed from /hal/rtl8188e_hal_init.c To: Greg Kroah-Hartman References: <20151010062313.GA22547@alpha.sfu-kras.ru> <20151013034706.GA6292@kroah.com> Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org From: Ivan Safonov Message-ID: <561D1C99.1070008@gmail.com> Date: Tue, 13 Oct 2015 22:00:41 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151013034706.GA6292@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2015 10:47 AM, Greg Kroah-Hartman wrote: > On Sat, Oct 10, 2015 at 01:23:13PM +0700, Ivan Safonov wrote: >> Unnecessary channel groups for 5 GHz removed from Hal_GetChnlGroup88E >> and it transformed to pretty get_channel_group(const u8 channel). >> >> Also removed code for 5 GHz frequency in Hal_ReadPowerValueFromPROM_8188E. > Why did you do two different things in this patch? > > Have you tested this? > > thanks, > > greg k-h Split this patch into two parts? I have not tested it.