From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932766AbbJMPrg (ORCPT ); Tue, 13 Oct 2015 11:47:36 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:34479 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932315AbbJMPrO (ORCPT ); Tue, 13 Oct 2015 11:47:14 -0400 Subject: Re: [PATCH 1/3] staging: rtl8188eu: 5 GHz channel groups removed from /hal/rtl8188e_hal_init.c To: Greg Kroah-Hartman References: <20151010062313.GA22547@alpha.sfu-kras.ru> <20151013034706.GA6292@kroah.com> <561D1C99.1070008@gmail.com> <20151013154031.GA6592@kroah.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ivan Safonov Message-ID: <561D27E8.8060604@gmail.com> Date: Tue, 13 Oct 2015 22:48:56 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151013154031.GA6592@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2015 10:40 PM, Greg Kroah-Hartman wrote: > On Tue, Oct 13, 2015 at 10:00:41PM +0700, Ivan Safonov wrote: >> On 10/13/2015 10:47 AM, Greg Kroah-Hartman wrote: >>> On Sat, Oct 10, 2015 at 01:23:13PM +0700, Ivan Safonov wrote: >>>> Unnecessary channel groups for 5 GHz removed from Hal_GetChnlGroup88E >>>> and it transformed to pretty get_channel_group(const u8 channel). >>>> >>>> Also removed code for 5 GHz frequency in Hal_ReadPowerValueFromPROM_8188E. >>> Why did you do two different things in this patch? >>> >>> Have you tested this? >>> >>> thanks, >>> >>> greg k-h >> Split this patch into two parts? > Why wouldn't you? > >> I have not tested it. > Please test it. > > thanks, > > greg k-h It is possible to test the driverwithout device?