From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964835AbbJMRgH (ORCPT ); Tue, 13 Oct 2015 13:36:07 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:36240 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932415AbbJMRgF (ORCPT ); Tue, 13 Oct 2015 13:36:05 -0400 Message-ID: <561D40E9.8030602@gmail.com> Date: Tue, 13 Oct 2015 10:35:37 -0700 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Vivien Didelot , netdev@vger.kernel.org CC: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Scott Feldman , Jiri Pirko , Andrew Lunn Subject: Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: write MAC outside of ATU Get Next code References: <1444754783-26975-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1444754783-26975-4-git-send-email-vivien.didelot@savoirfairelinux.com> In-Reply-To: <1444754783-26975-4-git-send-email-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/10/15 09:46, Vivien Didelot wrote: > There is no need to write the MAC address before every Get Next > operation, since ATU MAC registers are not cleared between calls. > > Move the _mv88e6xxx_atu_mac_write call outside of _mv88e6xxx_atu_getnext > so future code could call ATU Get Next multiple times and save a few > register access. Missing SoB tag here. -- Florian