From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751742AbbJMSnl (ORCPT ); Tue, 13 Oct 2015 14:43:41 -0400 Received: from mail-ob0-f180.google.com ([209.85.214.180]:33681 "EHLO mail-ob0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbbJMSnk (ORCPT ); Tue, 13 Oct 2015 14:43:40 -0400 Subject: Re: [PATCH v2 2/3] vTPM: reformat event log to be byte-aligned To: "Hon Ching(Vicky) Lo" , tpmdd-devel@lists.sourceforge.net References: <1444263114-15081-1-git-send-email-honclo@linux.vnet.ibm.com> <1444263114-15081-3-git-send-email-honclo@linux.vnet.ibm.com> Cc: Peter Huewe , Ashley Lai , Mimi Zohar , Vicky Lo , linux-kernel@vger.kernel.org From: Ashley Lai Message-ID: <561D50DA.9090605@gmail.com> Date: Tue, 13 Oct 2015 13:43:38 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1444263114-15081-3-git-send-email-honclo@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/07/2015 07:11 PM, Hon Ching(Vicky) Lo wrote: > The event log generated by OpenFirmware in PowerPC is 4-byte aligned. > This patch reformats the log to be byte-aligned for the Linux client. > > Signed-off-by: Hon Ching(Vicky) Lo > --- > arch/powerpc/kernel/prom_init.c | 13 ++++++++++++- > 1 files changed, 12 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c > index b9b6bb1..8a5c248 100644 > --- a/arch/powerpc/kernel/prom_init.c > +++ b/arch/powerpc/kernel/prom_init.c > @@ -1417,8 +1417,9 @@ static void __init prom_instantiate_sml(void) > { > phandle ibmvtpm_node; > ihandle ibmvtpm_inst; > - u32 entry = 0, size = 0; > + u32 entry = 0, size = 0, succ = 0; > u64 base; > + __be32 val; > > prom_debug("prom_instantiate_sml: start...\n"); > > @@ -1433,6 +1434,16 @@ static void __init prom_instantiate_sml(void) > return; > } > > + if (prom_getprop(ibmvtpm_node, "ibm,sml-efi-reformat-supported", > + &val, sizeof(val)) != PROM_ERROR) { > + if (call_prom_ret("call-method", 2, 2, &succ, > + ADDR("reformat-sml-to-efi-alignment"), > + ibmvtpm_inst) != 0 || succ == 0) { reformat-sml-to-efi-alignment is something new just added in the firmware? I don't remember seeing it before. > + prom_printf("Reformat SML to EFI alignment failed\n"); > + return; > + } > + } > + > if (call_prom_ret("call-method", 2, 2, &size, > ADDR("sml-get-handover-size"), > ibmvtpm_inst) != 0 || size == 0) {