From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752749AbbJMUGy (ORCPT ); Tue, 13 Oct 2015 16:06:54 -0400 Received: from hauke-m.de ([5.39.93.123]:41339 "EHLO hauke-m.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751973AbbJMUGx (ORCPT ); Tue, 13 Oct 2015 16:06:53 -0400 Subject: Re: [PATCH] PCI: iproc: fix 32-bit build error To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org References: <1442363962-29805-1-git-send-email-rjui@broadcom.com> <1442363962-29805-8-git-send-email-rjui@broadcom.com> <11199595.GgDE2yo8AA@wuerfel> Cc: Kevin Hilman , Ray Jui , Tyler Baker , lkml , Olof Johansson , Mark Brown , bcm-kernel-feedback-list@broadcom.com, Linux PCI , Bjorn Helgaas From: Hauke Mehrtens Message-ID: <561D6458.40504@hauke-m.de> Date: Tue, 13 Oct 2015 22:06:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <11199595.GgDE2yo8AA@wuerfel> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2015 10:02 PM, Arnd Bergmann wrote: > The iproc PCI driver tries to figure out whether the MMIO window has > a valid size, but does this using a 64-bit modulo operation, which > is not allowed on 32-bit kernels and leads to a link error: > > drivers/built-in.o: In function `iproc_pcie_setup': > :(.text+0x4b798): undefined reference to `__aeabi_uldivmod' > > This works around that error by using the div64_u64() function > provided by the kernel. While this is an expensive operation, > it is harmless because we only call it during the probing > of the driver. > > Signed-off-by: Arnd Bergmann > Fixes: 0ab99ca8eb6c ("PCI: iproc: Fix compile warnings") > > diff --git a/drivers/pci/host/pcie-iproc.c b/drivers/pci/host/pcie-iproc.c > index f3481ddff344..abcb4be2ee19 100644 > --- a/drivers/pci/host/pcie-iproc.c > +++ b/drivers/pci/host/pcie-iproc.c > @@ -235,12 +235,13 @@ static void iproc_pcie_enable(struct iproc_pcie *pcie) > * > * axi_addr -> iproc_pcie_address -> OARR -> OMAP -> pci_address > */ > -static int iproc_pcie_setup_ob(struct iproc_pcie *pcie, u64 axi_addr, > +int iproc_pcie_setup_ob(struct iproc_pcie *pcie, u64 axi_addr, Why are you removing the static here? > u64 pci_addr, resource_size_t size) > { > struct iproc_pcie_ob *ob = &pcie->ob; > unsigned i; > u64 max_size = (u64)ob->window_size * MAX_NUM_OB_WINDOWS; > + u64 remainder; > > if (size > max_size) { > dev_err(pcie->dev, > @@ -249,7 +250,8 @@ static int iproc_pcie_setup_ob(struct iproc_pcie *pcie, u64 axi_addr, > return -EINVAL; > } > > - if (size % ob->window_size) { > + div64_u64_rem(size, ob->window_size, &remainder); > + if (remainder) { > dev_err(pcie->dev, > "res size %pap needs to be multiple of window size %pap\n", > &size, &ob->window_size); >