From: Guenter Roeck <linux@roeck-us.net>
To: Lukasz Odzioba <lukasz.odzioba@intel.com>, fenghua.yu@intel.com
Cc: jdelvare@suse.de, lm-sensors@lm-sensors.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Bumps limit of maximum core ID from 32 to 128.
Date: Tue, 13 Oct 2015 18:17:15 -0700 [thread overview]
Message-ID: <561DAD1B.9010101@roeck-us.net> (raw)
In-Reply-To: <1444650812-17398-1-git-send-email-lukasz.odzioba@intel.com>
On 10/12/2015 04:53 AM, Lukasz Odzioba wrote:
> A new limit selected arbitrarily as power of two greater than
> required minimum for Xeon Phi processor.
>
> Currently driver is not able to handle cores with core ID greater than 32.
> Such attempt ends up with the following error in dmesg:
> coretemp coretemp.0: Adding Core XXX failed
>
> Signed-off-by: Lukasz Odzioba <lukasz.odzioba@intel.com>
Applied, after fixing up the subject and listing the current required limit
of 72 cores for Xeon Phi (per published information).
Guenter
> ---
> drivers/hwmon/coretemp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index 3e03379..6a27eb2 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -52,7 +52,7 @@ module_param_named(tjmax, force_tjmax, int, 0444);
> MODULE_PARM_DESC(tjmax, "TjMax value in degrees Celsius");
>
> #define BASE_SYSFS_ATTR_NO 2 /* Sysfs Base attr no for coretemp */
> -#define NUM_REAL_CORES 32 /* Number of Real cores per cpu */
> +#define NUM_REAL_CORES 128 /* Number of Real cores per cpu */
> #define CORETEMP_NAME_LENGTH 19 /* String Length of attrs */
> #define MAX_CORE_ATTRS 4 /* Maximum no of basic attrs */
> #define TOTAL_ATTRS (MAX_CORE_ATTRS + 1)
>
next prev parent reply other threads:[~2015-10-14 1:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 11:53 [PATCH 1/1] Bumps limit of maximum core ID from 32 to 128 Lukasz Odzioba
2015-10-13 20:31 ` Guenter Roeck
2015-10-13 21:05 ` [lm-sensors] " Phil Pokorny
2015-10-13 21:21 ` Guenter Roeck
2015-10-13 22:02 ` Odzioba, Lukasz
2015-10-13 22:26 ` Guenter Roeck
2015-10-13 22:45 ` Odzioba, Lukasz
2015-10-14 1:17 ` Guenter Roeck [this message]
2015-10-14 11:39 ` Odzioba, Lukasz
2015-10-14 14:04 ` Guenter Roeck
2015-10-15 22:08 ` Odzioba, Lukasz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561DAD1B.9010101@roeck-us.net \
--to=linux@roeck-us.net \
--cc=fenghua.yu@intel.com \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=lukasz.odzioba@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox