From: Yunlong Song <yunlong.song@huawei.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>,
Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Sriram Raghunathan <sriram.r@nokia.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
<wangnan0@huawei.com>
Subject: Re: [PATCH 1/1] perf:Adding --list-opts to usage string
Date: Wed, 14 Oct 2015 10:29:05 +0800 [thread overview]
Message-ID: <561DBDF1.1020503@huawei.com> (raw)
In-Reply-To: <CALkWK0mzW6naDQm5KLL2QCu=2MsJf_Pk35WPo_LcxCfts9E3tw@mail.gmail.com>
On 2015/10/13 23:24, Ramkumar Ramachandra wrote:
> Arnaldo Carvalho de Melo wrote:
>> Em Thu, Oct 08, 2015 at 10:59:50AM +0530, Sriram Raghunathan escreveu:
>>> Minor change, adding --list-opts to usage string. So that it is
>>> visible to the user on running perf --help. or just perf
>>> from command line.
>>
>>
>> Ramkumar, Yunlong, are you ok with this?
>
> Not sure I understand the motivation, but I suppose it can't hurt to
> show this detail?
>
> Ram
Agree with Ramkumar, --list-opts is redundant due to the existing [OPTIONS] in
the perf_usage_string[].
>>>
>>> const char perf_usage_string[] =
>>> - "perf [--version] [--help] [OPTIONS] COMMAND [ARGS]";
>>> + "perf [--version] [--help] [--list-opts] [OPTIONS] COMMAND [ARGS]";
--
Thanks,
Yunlong Song
next prev parent reply other threads:[~2015-10-14 2:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1444282190-13605-1-git-send-email-sriram.r@nokia.com>
2015-10-13 14:57 ` [PATCH 1/1] perf:Adding --list-opts to usage string Arnaldo Carvalho de Melo
2015-10-13 15:24 ` Ramkumar Ramachandra
2015-10-14 2:29 ` Yunlong Song [this message]
2015-10-14 3:10 ` Arnaldo Carvalho de Melo
2015-10-14 3:42 ` Namhyung Kim
2015-10-14 13:31 ` Yunlong Song
[not found] ` <CA+JHD92p0QUJGrqKTMYD8FUKj5tS9MUV_njsvoFwaHhsQevn_Q@mail.gmail.com>
2015-10-14 17:10 ` [PATCH 1/1] perf :redirection of usage strings to stdout Sriram Raghunathan
2015-10-15 7:22 ` Sriram Raghunathan
2015-10-15 7:11 ` [PATCH 1/1] perf:Adding --list-opts to usage string Yunlong Song
2015-10-14 13:44 ` [PATCH] perf help: Add options description to 'perf -h' Yunlong Song
2015-10-15 7:39 ` [PATCH v2 0/3] perf help: Make perf's help consistent with other builtins Yunlong Song
2015-10-15 7:39 ` [PATCH v2 1/3] perf help: Add options description to 'perf -h' Yunlong Song
2015-10-19 15:29 ` Namhyung Kim
2015-10-20 2:13 ` Yunlong Song
2015-10-21 1:57 ` Namhyung Kim
2015-10-15 7:39 ` [PATCH v2 2/3] perf help: Change 'usage' to 'Usage' for consistency Yunlong Song
2015-10-20 7:48 ` [tip:perf/core] " tip-bot for Yunlong Song
2015-10-15 7:39 ` [PATCH v2 3/3] perf help: Change the usage's stdout to stderr " Yunlong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561DBDF1.1020503@huawei.com \
--to=yunlong.song@huawei.com \
--cc=a.p.zijlstra@chello.nl \
--cc=arnaldo.melo@gmail.com \
--cc=artagnon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sriram.r@nokia.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).