From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197AbbJNC32 (ORCPT ); Tue, 13 Oct 2015 22:29:28 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:32907 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbbJNC30 (ORCPT ); Tue, 13 Oct 2015 22:29:26 -0400 Message-ID: <561DBDF1.1020503@huawei.com> Date: Wed, 14 Oct 2015 10:29:05 +0800 From: Yunlong Song User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Ramkumar Ramachandra , Arnaldo Carvalho de Melo CC: Sriram Raghunathan , Peter Zijlstra , Linux Kernel Mailing List , Subject: Re: [PATCH 1/1] perf:Adding --list-opts to usage string References: <1444282190-13605-1-git-send-email-sriram.r@nokia.com> <20151013145728.GT14409@kernel.org> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.74.205] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/10/13 23:24, Ramkumar Ramachandra wrote: > Arnaldo Carvalho de Melo wrote: >> Em Thu, Oct 08, 2015 at 10:59:50AM +0530, Sriram Raghunathan escreveu: >>> Minor change, adding --list-opts to usage string. So that it is >>> visible to the user on running perf --help. or just perf >>> from command line. >> >> >> Ramkumar, Yunlong, are you ok with this? > > Not sure I understand the motivation, but I suppose it can't hurt to > show this detail? > > Ram Agree with Ramkumar, --list-opts is redundant due to the existing [OPTIONS] in the perf_usage_string[]. >>> >>> const char perf_usage_string[] = >>> - "perf [--version] [--help] [OPTIONS] COMMAND [ARGS]"; >>> + "perf [--version] [--help] [--list-opts] [OPTIONS] COMMAND [ARGS]"; -- Thanks, Yunlong Song