From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751322AbbJNEFT (ORCPT <rfc822;w@1wt.eu>);
	Wed, 14 Oct 2015 00:05:19 -0400
Received: from cn.fujitsu.com ([59.151.112.132]:57838 "EHLO
	heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1750719AbbJNEFO (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 14 Oct 2015 00:05:14 -0400
X-IronPort-AV: E=Sophos;i="5.15,520,1432569600"; 
   d="scan'208";a="101811729"
Message-ID: <561DD40B.5060509@cn.fujitsu.com>
Date: Wed, 14 Oct 2015 12:03:23 +0800
From: Tang Chen <tangchen@cn.fujitsu.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: Xishi Qiu <qiuxishi@huawei.com>
CC: Yasuaki Ishimatsu <yasu.isimatu@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
        Mel Gorman <mgorman@suse.de>, David Rientjes <rientjes@google.com>,
        <zhongjiang@huawei.com>, Linux MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>, <tangchen@cn.fujitsu.com>
Subject: Re: [PATCH] mm: skip if required_kernelcore is larger than totalpages
References: <5615D311.5030908@huawei.com> <5617e00e.0c5b8c0a.2d0dd.3faa@mx.google.com> <561B0ECD.5000507@huawei.com> <561DC30C.70909@cn.fujitsu.com> <561DCBF9.4050000@huawei.com>
In-Reply-To: <561DCBF9.4050000@huawei.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/14/2015 11:28 AM, Xishi Qiu wrote:
> On 2015/10/14 10:50, Tang Chen wrote:
>
>> Hi, Qiu
>>
>> The patch seems OK to me. Only one little concern below.
>>
>> On 10/12/2015 09:37 AM, Xishi Qiu wrote:
>>> On 2015/10/9 23:41, Yasuaki Ishimatsu wrote:
>>>
>>>> On Thu, 8 Oct 2015 10:21:05 +0800
>>>> Xishi Qiu <qiuxishi@huawei.com> wrote:
>>>>
>>>>> If kernelcore was not specified, or the kernelcore size is zero
>>>>> (required_movablecore >= totalpages), or the kernelcore size is larger
>>>> Why does required_movablecore become larger than totalpages, when the
>>>> kernelcore size is zero? I read the code but I could not find that you
>>>> mention.
>>>>
>>> If user only set boot option movablecore, and the value is larger than
>>> totalpages, the calculation of kernelcore is zero, but we can't fill
>>> the zone only with kernelcore, so skip it.
>>>
>>> I have send a patch before this patch.
>>> "fix overflow in find_zone_movable_pfns_for_nodes()"
>>>          ...
>>>            required_movablecore =
>>>                roundup(required_movablecore, MAX_ORDER_NR_PAGES);
>>> +        required_movablecore = min(totalpages, required_movablecore);
>>>            corepages = totalpages - required_movablecore;
>>>          ...
>>
>> So if required_movablecore >= totalpages, there won't be any ZONE_MOVABLE.
>> How about add a warning or debug info to tell the user he has specified a
>> too large movablecore, and it is ignored ?
>>
>> Thanks.
> Yes, but I don't think is is necessary, user should know the total memory
> before he set the boot option.

Well, I'm just thinking if I set a too large movablecore, but I didn't 
realize it.
And when the system boots up, there is no ZONE_MOVABLE. It may confuse me.

Thanks.

>
> Thanks,
> Xishi Qiu
>
> .
>