From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752731AbbJNH1H (ORCPT ); Wed, 14 Oct 2015 03:27:07 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:34225 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751551AbbJNH1D (ORCPT ); Wed, 14 Oct 2015 03:27:03 -0400 Subject: Re: [PATCH] soc: qcom: smd-rpm: Correct the active vs sleep state flagging To: Bjorn Andersson , Andy Gross References: <1444769863-16190-1-git-send-email-bjorn.andersson@sonymobile.com> Cc: linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Georgi Djakov Message-ID: <561E03C4.5040203@linaro.org> Date: Wed, 14 Oct 2015 10:27:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1444769863-16190-1-git-send-email-bjorn.andersson@sonymobile.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2015 11:57 PM, Bjorn Andersson wrote: > The BIT() was incorrectly inherited from family A and should not be used > on family B where the state is denoted by an enum. > > Reported-by: Georgi Djakov > Signed-off-by: Bjorn Andersson Tested-by: Georgi Djakov > --- > drivers/soc/qcom/smd-rpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/smd-rpm.c b/drivers/soc/qcom/smd-rpm.c > index b5feb58dbd9f..2969321e1b09 100644 > --- a/drivers/soc/qcom/smd-rpm.c > +++ b/drivers/soc/qcom/smd-rpm.c > @@ -126,7 +126,7 @@ int qcom_rpm_smd_write(struct qcom_smd_rpm *rpm, > pkt->hdr.length = cpu_to_le32(sizeof(struct qcom_rpm_request) + count); > > pkt->req.msg_id = cpu_to_le32(msg_id++); > - pkt->req.flags = cpu_to_le32(BIT(state)); > + pkt->req.flags = cpu_to_le32(state); > pkt->req.type = cpu_to_le32(type); > pkt->req.id = cpu_to_le32(id); > pkt->req.data_len = cpu_to_le32(count); >