From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752912AbbJNHrp (ORCPT <rfc822;w@1wt.eu>);
	Wed, 14 Oct 2015 03:47:45 -0400
Received: from mga02.intel.com ([134.134.136.20]:4923 "EHLO mga02.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752624AbbJNHro (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 14 Oct 2015 03:47:44 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,681,1437462000"; 
   d="scan'208";a="664001173"
Subject: Re: [PATCH] mfd: axp20x: Add a cell for the power button part of
 the,axp288 PMICs
To: Lee Jones <lee.jones@linaro.org>, "Yang, Fei" <fei.yang@intel.com>
References: <561B5E55.3010802@linux.intel.com> <20151013081148.GZ17172@x1>
 <02E7334B1630744CBDC55DA8586225834A6F8C6B@ORSMSX102.amr.corp.intel.com>
 <20151014070816.GD32409@x1>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Pallala, Ramakrishna" <ramakrishna.pallala@intel.com>,
        "jacob.jun.pan@linux.intel.com" <jacob.jun.pan@linux.intel.com>
From: Borun Fu <borun.fu@linux.intel.com>
Message-ID: <561E0897.9050500@linux.intel.com>
Date: Wed, 14 Oct 2015 15:47:35 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151014070816.GD32409@x1>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

So the patch will be refined to remove the comment as follows. Any else comments? 
@@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
 		.resources = axp288_fuel_gauge_resources,
 	},
 	{
+		.name = "axp20x-pek",
+		.num_resources = ARRAY_SIZE(axp288_power_button_resources),
+		.resources = axp288_power_button_resources,
+	},
+	{
 		.name = "axp288_pmic_acpi",
 	},
 };

On 10/14/2015 15:08, Lee Jones wrote:
> On Tue, 13 Oct 2015, Yang, Fei wrote:
> 
>>>>  static struct resource axp288_fuel_gauge_resources[] = {
>>>>  	{
>>>>  		.start = AXP288_IRQ_QWBTU,
>>>> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
>>>>  		.resources = axp288_fuel_gauge_resources,
>>>>  	},
>>>>  	{
>>>> +		.name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
>>>
>>> Doesn't this change insinuate that?
>>>
>>> If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right? 
>>
>> Are you suggesting to remove the comment? Just want to make sure I understand you correctly.
> 
> I am.
> 
>>>> +		.num_resources = ARRAY_SIZE(axp288_power_button_resources),
>>>> +		.resources = axp288_power_button_resources,
>>>> +	},
>>>> +	{
>>>>  		.name = "axp288_pmic_acpi",
>>>>  	},
>>>>  };
>>
>