[PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs

[PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs

[Borun Fu]

This patch adds the mfd cell info for axp288 power key device.

Signed-off-by: Borun Fu <borun.fu@linux.intel.com>
Signed-off-by: Fei Yang <fei.yang@intel.com>
---
 drivers/mfd/axp20x.c |   20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index 3f576b7..3f4e11f 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c
@@ -161,6 +161,21 @@ static struct resource axp22x_pek_resources[] = {
 	},
 };
 
+static struct resource axp288_power_button_resources[] = {
+	{
+		.name	= "PEK_DBR",
+		.start	= AXP288_IRQ_POKN,
+		.end	= AXP288_IRQ_POKN,
+		.flags	= IORESOURCE_IRQ,
+	},
+	{
+		.name	= "PEK_DBF",
+		.start	= AXP288_IRQ_POKP,
+		.end	= AXP288_IRQ_POKP,
+		.flags	= IORESOURCE_IRQ,
+	},
+};
+
 static struct resource axp288_fuel_gauge_resources[] = {
 	{
 		.start = AXP288_IRQ_QWBTU,
@@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
 		.resources = axp288_fuel_gauge_resources,
 	},
 	{
+		.name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
+		.num_resources = ARRAY_SIZE(axp288_power_button_resources),
+		.resources = axp288_power_button_resources,
+	},
+	{
 		.name = "axp288_pmic_acpi",
 	},
 };
-- 
1.7.10.4

Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs

[Lee Jones]

On Mon, 12 Oct 2015, Borun Fu wrote:

> This patch adds the mfd cell info for axp288 power key device.
> 
> Signed-off-by: Borun Fu <borun.fu@linux.intel.com>
> Signed-off-by: Fei Yang <fei.yang@intel.com>
> ---
>  drivers/mfd/axp20x.c |   20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 3f576b7..3f4e11f 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -161,6 +161,21 @@ static struct resource axp22x_pek_resources[] = {
>  	},
>  };
>  
> +static struct resource axp288_power_button_resources[] = {
> +	{
> +		.name	= "PEK_DBR",
> +		.start	= AXP288_IRQ_POKN,
> +		.end	= AXP288_IRQ_POKN,
> +		.flags	= IORESOURCE_IRQ,
> +	},
> +	{
> +		.name	= "PEK_DBF",
> +		.start	= AXP288_IRQ_POKP,
> +		.end	= AXP288_IRQ_POKP,
> +		.flags	= IORESOURCE_IRQ,
> +	},
> +};
> +
>  static struct resource axp288_fuel_gauge_resources[] = {
>  	{
>  		.start = AXP288_IRQ_QWBTU,
> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
>  		.resources = axp288_fuel_gauge_resources,
>  	},
>  	{
> +		.name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */

Doesn't this change insinuate that?

If axp20x-pek didn't work for AXP288 you wouldn't have put it in this
structure right? 

> +		.num_resources = ARRAY_SIZE(axp288_power_button_resources),
> +		.resources = axp288_power_button_resources,
> +	},
> +	{
>  		.name = "axp288_pmic_acpi",
>  	},
>  };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

RE: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs

[Yang, Fei]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1015 bytes --]

>>  static struct resource axp288_fuel_gauge_resources[] = {
>>  	{
>>  		.start = AXP288_IRQ_QWBTU,
>> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
>>  		.resources = axp288_fuel_gauge_resources,
>>  	},
>>  	{
>> +		.name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
>
>Doesn't this change insinuate that?
>
>If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right? 
>

Are you suggesting to remove the comment? Just want to make sure I understand you correctly.

>> +		.num_resources = ARRAY_SIZE(axp288_power_button_resources),
>> +		.resources = axp288_power_button_resources,
>> +	},
>> +	{
>>  		.name = "axp288_pmic_acpi",
>>  	},
>>  };

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs

[Lee Jones]

On Tue, 13 Oct 2015, Yang, Fei wrote:

> >>  static struct resource axp288_fuel_gauge_resources[] = {
> >>  	{
> >>  		.start = AXP288_IRQ_QWBTU,
> >> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
> >>  		.resources = axp288_fuel_gauge_resources,
> >>  	},
> >>  	{
> >> +		.name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
> >
> >Doesn't this change insinuate that?
> >
> >If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right? 
> 
> Are you suggesting to remove the comment? Just want to make sure I understand you correctly.

I am.

> >> +		.num_resources = ARRAY_SIZE(axp288_power_button_resources),
> >> +		.resources = axp288_power_button_resources,
> >> +	},
> >> +	{
> >>  		.name = "axp288_pmic_acpi",
> >>  	},
> >>  };
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs

[Borun Fu]

So the patch will be refined to remove the comment as follows. Any else comments? 
@@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
 		.resources = axp288_fuel_gauge_resources,
 	},
 	{
+		.name = "axp20x-pek",
+		.num_resources = ARRAY_SIZE(axp288_power_button_resources),
+		.resources = axp288_power_button_resources,
+	},
+	{
 		.name = "axp288_pmic_acpi",
 	},
 };

On 10/14/2015 15:08, Lee Jones wrote:
> On Tue, 13 Oct 2015, Yang, Fei wrote:
> 
>>>>  static struct resource axp288_fuel_gauge_resources[] = {
>>>>  	{
>>>>  		.start = AXP288_IRQ_QWBTU,
>>>> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
>>>>  		.resources = axp288_fuel_gauge_resources,
>>>>  	},
>>>>  	{
>>>> +		.name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
>>>
>>> Doesn't this change insinuate that?
>>>
>>> If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right? 
>>
>> Are you suggesting to remove the comment? Just want to make sure I understand you correctly.
> 
> I am.
> 
>>>> +		.num_resources = ARRAY_SIZE(axp288_power_button_resources),
>>>> +		.resources = axp288_power_button_resources,
>>>> +	},
>>>> +	{
>>>>  		.name = "axp288_pmic_acpi",
>>>>  	},
>>>>  };
>>
> 

Re: [PATCH] mfd: axp20x: Add a cell for the power button part of the,axp288 PMICs

[Lee Jones]

On Wed, 14 Oct 2015, Borun Fu wrote:

> So the patch will be refined to remove the comment as follows. Any
> else comments? 

Please don't top post.  If you have a comment about something that was
said, please make your comment directly _after_ it (a.k.a inline).

> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
>  		.resources = axp288_fuel_gauge_resources,
>  	},
>  	{
> +		.name = "axp20x-pek",
> +		.num_resources = ARRAY_SIZE(axp288_power_button_resources),
> +		.resources = axp288_power_button_resources,
> +	},
> +	{
>  		.name = "axp288_pmic_acpi",
>  	},
>  };

No need to do this.  It doesn't save anyone any time.

Just resubmit the next version of the patch.

> On 10/14/2015 15:08, Lee Jones wrote:
> > On Tue, 13 Oct 2015, Yang, Fei wrote:
> > 
> >>>>  static struct resource axp288_fuel_gauge_resources[] = {
> >>>>  	{
> >>>>  		.start = AXP288_IRQ_QWBTU,
> >>>> @@ -572,6 +587,11 @@ static struct mfd_cell axp288_cells[] = {
> >>>>  		.resources = axp288_fuel_gauge_resources,
> >>>>  	},
> >>>>  	{
> >>>> +		.name = "axp20x-pek", /* axp20x-pek works for AXP288 as well */
> >>>
> >>> Doesn't this change insinuate that?
> >>>
> >>> If axp20x-pek didn't work for AXP288 you wouldn't have put it in this structure right? 
> >>
> >> Are you suggesting to remove the comment? Just want to make sure I understand you correctly.
> > 
> > I am.
> > 
> >>>> +		.num_resources = ARRAY_SIZE(axp288_power_button_resources),
> >>>> +		.resources = axp288_power_button_resources,
> >>>> +	},
> >>>> +	{
> >>>>  		.name = "axp288_pmic_acpi",
> >>>>  	},
> >>>>  };
> >>
> > 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog