From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753184AbbJNJBX (ORCPT ); Wed, 14 Oct 2015 05:01:23 -0400 Received: from foss.arm.com ([217.140.101.70]:56816 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752486AbbJNJBT (ORCPT ); Wed, 14 Oct 2015 05:01:19 -0400 Subject: Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property To: Simon Horman References: <1444743164-17735-1-git-send-email-sudeep.holla@arm.com> <20151014001351.GB24693@verge.net.au> Cc: Sudeep Holla , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Kevin Hilman , Arnd Bergmann , Linus Walleij , Magnus Damm , Olof Johansson , linux-sh@vger.kernel.org From: Sudeep Holla Message-ID: <561E19DB.8040701@arm.com> Date: Wed, 14 Oct 2015 10:01:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151014001351.GB24693@verge.net.au> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/10/15 01:13, Simon Horman wrote: > [cc linux-sh] > > On Tue, Oct 13, 2015 at 02:32:43PM +0100, Sudeep Holla wrote: >> The keyboard driver for GPIO buttons(gpio-keys) checks for one of the >> two boolean properties to enable gpio buttons as wakeup source: >> 1. "wakeup-source" or >> 2. the legacy "gpio-key,wakeup" >> >> However juno, ste-snowball and emev2-kzm9d dts file have a undetected >> "wakeup" property to indictate the wakeup source. >> >> This patch fixes it by making use of "wakeup-source" property. >> >> Cc: Simon Horman >> Cc: Magnus Damm >> Cc: Linus Walleij >> Signed-off-by: Sudeep Holla >> --- >> arch/arm/boot/dts/emev2-kzm9d.dts | 8 ++++---- >> arch/arm/boot/dts/ste-snowball.dts | 10 +++++----- >> arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 12 ++++++------ >> 3 files changed, 15 insertions(+), 15 deletions(-) > > emev2-kzm9d portion: > > Acked-by: Simon Horman > > My preferred course of action would be to take that portion through the > renesas tree if it was broken out into a separate patch. But I won't > object if someone wants to take the whole patch/series. I can split this patch, but it is more like a bug fix IMO, I can't use these GPIO as wakeup on Juno. So I hope arm-soc guys take it directly. If not, I can split and sent it separately. -- Regards, Sudeep