From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753632AbbJNLxI (ORCPT ); Wed, 14 Oct 2015 07:53:08 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:50833 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753193AbbJNLxG (ORCPT ); Wed, 14 Oct 2015 07:53:06 -0400 Subject: Re: [PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT To: Franklin S Cooper Jr , , , , , , , , References: <1444700338-27582-1-git-send-email-fcooper@ti.com> <1444700338-27582-2-git-send-email-fcooper@ti.com> <561E3E4F.9020302@ti.com> From: Roger Quadros Message-ID: <561E41EB.3050005@ti.com> Date: Wed, 14 Oct 2015 14:52:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <561E3E4F.9020302@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Franklin, On 14/10/15 14:36, Roger Quadros wrote: > On 13/10/15 04:38, Franklin S Cooper Jr wrote: >> Switch from dma_request_channel to allow passing dma channel >> information from DT rather than hardcoding a value. >> >> Signed-off-by: Franklin S Cooper Jr > > Acked-by: Roger Quadros > >> --- >> drivers/mtd/nand/omap2.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c >> index d0f2620..957c32f 100644 >> --- a/drivers/mtd/nand/omap2.c >> +++ b/drivers/mtd/nand/omap2.c >> @@ -1866,7 +1866,9 @@ static int omap_nand_probe(struct platform_device *pdev) >> dma_cap_zero(mask); >> dma_cap_set(DMA_SLAVE, mask); >> sig = OMAP24XX_DMA_GPMC; >> - info->dma = dma_request_channel(mask, omap_dma_filter_fn, &sig); >> + info->dma = dma_request_slave_channel_compat(mask, >> + omap_dma_filter_fn, &sig, pdev->dev.parent, "rxtx"); >> + Just discovered that you are using the parent device node. How about moving the dma bindings to the nand node instead and using pdev->dev here? >> if (!info->dma) { >> dev_err(&pdev->dev, "DMA engine request failed\n"); >> err = -ENXIO; >> > cheers, -roger