From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753052AbbJNMlN (ORCPT ); Wed, 14 Oct 2015 08:41:13 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([207.82.80.143]:23107 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751731AbbJNMlJ convert rfc822-to-8bit (ORCPT ); Wed, 14 Oct 2015 08:41:09 -0400 Subject: Re: [PATCHv3 01/11] arm64: Move swapper pagetable definitions To: Mark Rutland References: <1444821634-1689-1-git-send-email-suzuki.poulose@arm.com> <1444821634-1689-2-git-send-email-suzuki.poulose@arm.com> <20151014114247.GA2150@leverpostej> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, steve.capper@linaro.org, marc.zyngier@arm.com, ard.biesheuvel@linaro.org, christoffer.dall@linaro.org From: "Suzuki K. Poulose" Message-ID: <561E4D61.7000000@arm.com> Date: Wed, 14 Oct 2015 13:41:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20151014114247.GA2150@leverpostej> X-OriginalArrivalTime: 14 Oct 2015 12:41:05.0885 (UTC) FILETIME=[97DB10D0:01D1067D] X-MC-Unique: hIgyMuoLRcyh3tWWPvljIg-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/10/15 12:42, Mark Rutland wrote: > On Wed, Oct 14, 2015 at 12:20:24PM +0100, Suzuki K. Poulose wrote: >> >> Also renames the symbols to prevent conflicts. e.g, >> BLOCK_SHIFT => SWAPPER_BLOCK_SHIFT > > This sounds sensible to be, so FWIW: > > Acked-by: Mark Rutland > > I have a couple of minor nits below, though. >> diff --git a/arch/arm64/include/asm/kernel-pgtable.h b/arch/arm64/include/asm/kernel-pgtable.h >> new file mode 100644 >> index 0000000..622929d >> --- /dev/null >> +++ b/arch/arm64/include/asm/kernel-pgtable.h >> @@ -0,0 +1,65 @@ >> +/* >> + * asm/kernel-pgtable.h : Kernel page table mapping > > Drop the filename from the comment. It's redundant and ends up being > painful when refactoring and moving things around. > OK >> + >> + >> +#endif > > It would be nice to have the usual comment here for what this is ending, > i.e. > > #endif /* __ASM_KERNEL_PGTABLE_H */ Oh yes, will add it. Thanks Suzuki