From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932527AbbJNPMi (ORCPT ); Wed, 14 Oct 2015 11:12:38 -0400 Received: from smtp-out-188.synserver.de ([212.40.185.188]:1057 "EHLO smtp-out-188.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932430AbbJNPMh (ORCPT ); Wed, 14 Oct 2015 11:12:37 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 12948 Message-ID: <561E70E0.1010508@metafoo.de> Date: Wed, 14 Oct 2015 17:12:32 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Martin Kepplinger , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net, mfuzzey@parkeon.com CC: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Martin Kepplinger Subject: Re: [PATCH v3] iio: mma8452: support either of the available interrupt pins References: <1444828542-28861-1-git-send-email-martink@posteo.de> In-Reply-To: <1444828542-28861-1-git-send-email-martink@posteo.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/14/2015 03:15 PM, Martin Kepplinger wrote: [...] > + if (irq1 > 0) > + client->irq = irq1; You must not overwrite client->irq, that field is manged by the I2C core and is supposed to be read only for device drivers. > + dev_info(&client->dev, "using interrupt line INT1\n"); This should probably be a dev_dbg() > + } else { > + client->irq = irq2; > + dev_info(&client->dev, "using interrupt line INT2\n"); Same here > + }