From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932603AbbJNP2E (ORCPT ); Wed, 14 Oct 2015 11:28:04 -0400 Received: from foss.arm.com ([217.140.101.70]:59094 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932430AbbJNP2A (ORCPT ); Wed, 14 Oct 2015 11:28:00 -0400 Subject: Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <1444743164-17735-1-git-send-email-sudeep.holla@arm.com> Cc: Sudeep Holla , Kevin Hilman , Olof Johansson , Arnd Bergmann , Simon Horman , Magnus Damm , Linus Walleij From: Sudeep Holla Message-ID: <561E747D.1040100@arm.com> Date: Wed, 14 Oct 2015 16:27:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1444743164-17735-1-git-send-email-sudeep.holla@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, On 13/10/15 14:32, Sudeep Holla wrote: > The keyboard driver for GPIO buttons(gpio-keys) checks for one of the > two boolean properties to enable gpio buttons as wakeup source: > 1. "wakeup-source" or > 2. the legacy "gpio-key,wakeup" > > However juno, ste-snowball and emev2-kzm9d dts file have a undetected > "wakeup" property to indictate the wakeup source. > > This patch fixes it by making use of "wakeup-source" property. > > Cc: Simon Horman > Cc: Magnus Damm > Cc: Linus Walleij Please review this and provide ack if you are fine with the change for ste-snowball. I can then ask arm-soc guys to pick this up as fix for v4.3 -- Regards, Sudeep