From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932550AbbJNPlH (ORCPT ); Wed, 14 Oct 2015 11:41:07 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:13082 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932103AbbJNPlE convert rfc822-to-8bit (ORCPT ); Wed, 14 Oct 2015 11:41:04 -0400 Subject: Re: [PATCHv3 10/11] arm64: Add 16K page size support To: "Suzuki K. Poulose" , linux-arm-kernel@lists.infradead.org References: <1444821634-1689-1-git-send-email-suzuki.poulose@arm.com> <1444821634-1689-11-git-send-email-suzuki.poulose@arm.com> Cc: linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, mark.rutland@arm.com, steve.capper@linaro.org, marc.zyngier@arm.com, ard.biesheuvel@linaro.org, christoffer.dall@linaro.org From: Jeremy Linton Message-ID: <561E7788.6080900@arm.com> Date: Wed, 14 Oct 2015 10:40:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1444821634-1689-11-git-send-email-suzuki.poulose@arm.com> X-OriginalArrivalTime: 14 Oct 2015 15:41:00.0303 (UTC) FILETIME=[B9D489F0:01D10696] X-MC-Unique: 1QRGr4W0RtmTkrxIRULUQg-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/14/2015 06:20 AM, Suzuki K. Poulose wrote: > diff --git a/arch/arm64/include/asm/page.h b/arch/arm64/include/asm/page.h > index da32354..736ed4c 100644 > --- a/arch/arm64/include/asm/page.h > +++ b/arch/arm64/include/asm/page.h > @@ -24,6 +24,9 @@ > #ifdef CONFIG_ARM64_64K_PAGES > #define PAGE_SHIFT 16 > #define CONT_SHIFT 5 > +#elif defined(CONFIG_ARM64_16K_PAGES) > +#define PAGE_SHIFT 14 > +#define CONT_SHIFT 9 > #else > #define PAGE_SHIFT 12 > #define CONT_SHIFT 4 Suzuki, Is CONT_SHIFT correct? I thought it should be 7? The ARM-ARM says that a contiguous 3rd level lookup is 128 entries. Thanks, Jeremy