Re: [PATCH] staging: octeon: fixed few coding style warnings

David Daney
2015-10-15T16:58:41Z

On 10/15/2015 06:40 AM, Dan Carpenter wrote:
> On Wed, Oct 14, 2015 at 09:09:04AM -0700, David Daney wrote:
>> and make sure you don't break the driver.
>
> I'm not seeing how this patch breaks anything? What am I missing?

Did you apply it and then compile the result? If not, then how can you
assert that it does not break anything?

From SubmitChecklist item #2: "Builds cleanly ..."

I don't want to waste time considering patches that don't, at a minimum,
meet this criterion. Other people may want to do the build testing, but
I prefer that the patch submitter at least vet the patch enough that
they can assert that it still builds cleanly.

David Daney