Re: [PATCH] staging: octeon: fixed few coding style warnings

Aaro Koskinen
2015-10-14T19:35:39Z

Hi,

On Wed, Oct 14, 2015 at 07:36:37PM +0530, Sakshi Bansal wrote:
> Fixed allignment issues and line over 80 characters

You are also doing many other things which are not mention in the
commit log.

> /*
> - printk_ratelimited("Port %d received 0xd5 preamble\n",
> - port);
> + * printk_ratelimited("Port %d received 0xd5 preamble\n"
> + * port);
> */

This is not really an improvement. Either the dead code should be deleted
altogether or converted to debug printk()s. (Probably the idea has been
that those printk()s can be "easily" enabled for debugging by removing
comment start/end marks.)

You also removed a comma there, breaking the syntax...

A.