From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932303AbbJNTIl (ORCPT ); Wed, 14 Oct 2015 15:08:41 -0400 Received: from lists.s-osg.org ([54.187.51.154]:54234 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754458AbbJNTIj (ORCPT ); Wed, 14 Oct 2015 15:08:39 -0400 Subject: Re: [PATCH] clk: Allow drivers to build if COMPILE_TEST is enabled To: Stephen Boyd References: <1444745898-11537-1-git-send-email-javier@osg.samsung.com> <20151014183831.GH26883@codeaurora.org> From: Javier Martinez Canillas X-Enigmail-Draft-Status: N1110 Cc: linux-kernel@vger.kernel.org, Luis de Bethencourt , Michael Turquette , Scott Branden , Ray Jui , linux-clk@vger.kernel.org Message-ID: <561EA831.2070001@osg.samsung.com> Date: Wed, 14 Oct 2015 21:08:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151014183831.GH26883@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Stephen, On 10/14/2015 08:38 PM, Stephen Boyd wrote: > On 10/13, Javier Martinez Canillas wrote: >> diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig >> index 1530c9352a76..fc50b6264bed 100644 >> --- a/drivers/clk/versatile/Kconfig >> +++ b/drivers/clk/versatile/Kconfig >> @@ -1,6 +1,6 @@ >> config COMMON_CLK_VERSATILE >> bool "Clock driver for ARM Reference designs" >> - depends on ARCH_INTEGRATOR || ARCH_REALVIEW || ARCH_VEXPRESS || ARM64 >> + depends on ARCH_INTEGRATOR || ARCH_REALVIEW || ARCH_VEXPRESS || ARM64 || COMPILE_TEST > > Have you compiled these drivers on an architecture that doesn't > have IOMEM? Perhaps tile or um? I'm all for more build coverage, > but it's not always as simple as just sprinkling some > COMPILE_TEST around the Kconfigs. > No, I only build tested on arm32 and x86. The 0-day bot haven't reported a build error yet and I didn't see any platform dependent code in the drivers. But you are right that COMPILE_TEST is a little tricky, so maybe is safest to drop this patch. Is just that it would be nice to build as much as possible to make sure that subystemms or kernel wide changes don't introduce regressions since that is also tricky even when using tools like coccinelle. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America