From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754759AbbJNVET (ORCPT ); Wed, 14 Oct 2015 17:04:19 -0400 Received: from mail-by2on0078.outbound.protection.outlook.com ([207.46.100.78]:61520 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754040AbbJNVEO (ORCPT ); Wed, 14 Oct 2015 17:04:14 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@caviumnetworks.com; Message-ID: <561EC340.8050304@caviumnetworks.com> Date: Wed, 14 Oct 2015 14:04:00 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Arnd Bergmann CC: Sakshi Bansal , , , , , , , , , , , , , , , , Subject: Re: [PATCH] staging: octeon: fixed few coding style warnings References: <20151014140637.GA23007@localhost.localdomain> <561E7920.2000903@caviumnetworks.com> <6531068.KI8IQomEHc@wuerfel> In-Reply-To: <6531068.KI8IQomEHc@wuerfel> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: BLUPR07CA072.namprd07.prod.outlook.com (25.160.24.27) To BN4PR07MB2129.namprd07.prod.outlook.com (25.164.63.11) X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2129;2:wXBtcO1qKjNzCXHe5denxQL9QtT3noIpj8lng2rui4D7y/q0QxcU/DlTI9cidGVlwPXrD+SuDhHy1zIk4vfOkV1Ef5aaARMzjyXQbnfMRe99Cd64FuZPWz1POOMR3npGq5EVI7vAd+JXDIftV2hZ4DBcrQ6Nri4BydRcqiPyozY=;3:PqoRnekyRd/os8M5B7wR4Fex8wlDga1otvX/phB1r2eOFlCJc5GyEgPSFTobQgt8JY9HTfChnTXJyC+Yu/GVQg/7rlp2YWuw1qTTO2WNcmYKZ/hDIErqxutJVOAKIIZX4rGWWlkrLZWR4E3H9t8lQQ==;25:Lxi0w15gkdSAusXtRX45lK29pyjKjbJqAPjq5l0OeMnC8FiQ6aVaJzLBKbWUN0icxZq2Kwnrv3y28G7bv6BJUtitQ9hAwypM2ef+pFSEADA57bCMqjggtwE24pAqt9cSnTuE/uyVsidp60Ys2fUHwtSWocC8fRcPMXeFQ3WRhmRQvZRRS8T06qYA7MjwhUh5NFPd2AQLurUxJLa5yzXPG0/OnY3iAouEflJfXC7wrQUNws5RW13G1uxgVGDJuwqnsYnWX9kyRTRHJgZXOVBq1g== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2129; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2129;20:sP4aYDSD/Fo+JpbAMf7My0jukD89/QihUaaBGyga9msf0zgkJHBCv3sur3uQhIdb/Jv6cGXkL7SoJ9QNQcaj3hxRCmjcRIkyLGSnLJO1LTlLYJa2vXWn9q25Azsi4sHKDGcEdhO3G5amJbeamiPc7ZsgKUJiw1/oXO7SPEhg3mJmR1cFExRlPxm24YipPbSB1dTMKgtlemNuVdAQJbSwVHjRm30vhtr/BLUK1PfMcosK083dcBXCSrUzLrzeuoM+ZralYqYz6QxqcpNcGXaCbweiejDS1UsdEemNzHv9/pdJlQurZ7idY/1eNf/Zt5nBS6c32VE6tr+HKeQ5foEUgXfPnfptkex/Vm6fkWN+JSLDSNiraLJJSmnxKwv2apUS1KfYqBffpombFYaFepB2TvvXznFHJ9mnoEwDx5fxgiWqXQZW8dpkhjRzhMYRlUf7H7otPWgE7y2xwwftcUx0lo2GlDIOR4KCyCHOYSErW91vwZp1QzSbSKjY3zqcEVZztlXPfAmnl3zbFKVYqAHmQtCUfqghItXmL1Y4s6wZcyjAIlCah+K9Ft7Po4AcmHBhjRfZOLxiMNj3NLyajQx33hfHrgdqdnp/oeMRScLs++w= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(3002001);SRVR:BN4PR07MB2129;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2129; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2129;4:xs2PMm6ugPQUtQBG+tOp7OBSTw9CgDV4WI6BckMw0K9YdDeyEgsyfsx2OlGh/z5iIsJSR09D3P0gh3jloOVm9fX9NihVRvpfRofoJj2+TbmWm0mP9atAXuVyTNXpTd42xmgd9T6kMxKSISDhMtvGevVhHgDOXPvkgUZHtIZGQeJ4YG/PT/YGs+KV2UoatBDy4dQLV+u3qotRqTMwcFk+OP/qCEPOaiNqJPFd7wBeAb3XZEGq2CiBOw4DzqqoF+A5MTVDRGLBiWEqOtQWtuxkn6cFkqmxhebDJT30EDTfkACI3PI2qG54MkxW6TPu8wT3mZoRnuM4a4WxEPAotKixfQptEt5uOGhNl4J1iggAnz8= X-Forefront-PRVS: 0729050452 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(189002)(199003)(479174004)(24454002)(377454003)(53416004)(2950100001)(19580395003)(69596002)(87266999)(122386002)(189998001)(83506001)(80316001)(40100003)(77096005)(15975445007)(4001350100001)(106356001)(97736004)(105586002)(33656002)(50986999)(81156007)(54356999)(76176999)(65956001)(66066001)(47776003)(64126003)(64706001)(101416001)(110136002)(5001960100002)(65806001)(42186005)(65816999)(46102003)(50466002)(23756003)(5008740100001)(5004730100002)(5007970100001)(87976001)(59896002)(36756003)(92566002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2129;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;BN4PR07MB2129;23:j0fsHIb4wJ+jPqe/Z3lC8UJ4GdEnM1yJfGUgZbV?= =?iso-8859-1?Q?ivhNI+eb263O6iJGMDg/9OI6TRPST6F3eN1EXm0MgPVxAjcxpwrNJXo+kA?= =?iso-8859-1?Q?+/uvljy2BdZ8DTr/iE7TI1k+qggrlcrfygfm0lXh+9mTi5F8XmxumBQa96?= =?iso-8859-1?Q?tI1eYqycrYOF54/SG0uqYHI0ABoQQB16jx+DpIuFZl3BUhyBbFAe9g2aSc?= =?iso-8859-1?Q?QCwpt3EeYCkn+b6rY6V7FQEw+XrMBfmD2sPtNDWmifV28tYbfzJQoywoJ+?= =?iso-8859-1?Q?xzH8vLQo8znxSE1LnWz/xgAKPUXi0K0QbsusFQfsyP2QD/9ZsxJv79WseW?= =?iso-8859-1?Q?V7GFiH6f/8UsKG1tbhilnQx+pDycsgDcacC8IhxUFQ9Sd9BqYMUM2/7WJn?= =?iso-8859-1?Q?Y/bAW8yd0NECoObj05I0lLGSTgkX1nbg3epP65eP2siEPKDOyxSUFw8AoZ?= =?iso-8859-1?Q?V8pjIraRwoHYAXiyRmGZmFdIrrce8F3AvRw4lkgz1SuTJx25hzcY9CkxiZ?= =?iso-8859-1?Q?MGYuDu+Klf17ShliPKHbEuk53+Fl8+eNfY5Gg9XUHCYnLY80eCA2e3VctI?= =?iso-8859-1?Q?taX1jbNvUG+vMmxW8wBifT/uazOapgvwV/H7ZQU/jcTXAubxAAq/FAiyqG?= =?iso-8859-1?Q?wdqas6hfGJ7EH/AdyGIjdFUXrq0+F2NygXXM+pNPtOK15X7S4LAro5Sj5t?= =?iso-8859-1?Q?XU6UOJJZk4JUP/pC1nXA4MayBAYBBSu7JGonSUPe7aViRj+axsA6gc/Odv?= =?iso-8859-1?Q?Q8ZUJYJ6R6Qs0fbQ05YDQkVLlOkLMqQflX3CS4vf3GGNh8A0AdW2Nvxehs?= =?iso-8859-1?Q?Jh6kAQBtydf0wVaVMBtf8geeucelKIXxmlKm9fzb3JumFPaPYgDl5l3fgR?= =?iso-8859-1?Q?o6OtqTwED00fhLWnwqWsjeW5qZftZRc8O47Hmp6Elnk0vHacs7PgKfvX6m?= =?iso-8859-1?Q?ln4K096qvd21hu6dwhRWDaDlrpseagH3XBwlrPyheOh0zTO812qY5mqisL?= =?iso-8859-1?Q?81G6IecU03cBijKbaI4LWxHXDbsezOJLTnc0uW5mL293W6IxTcAX5MUFNo?= =?iso-8859-1?Q?1+jrrFVZN5wLdxwc2H8dKtlpRErmnt0Id2ygRVDHQTRIX5issDQ0VvwrIZ?= =?iso-8859-1?Q?GgVkaaDi0arhnTA2j9kVAH+AtJpwc7wpRQaxmEuAry/KzuRp9gnkZczMRN?= =?iso-8859-1?Q?hgKExgHRQRM3JT/+Fc3dA2VkQB/7Zlg0ARsMJ17LKrpjamr4P+XMm6PgMl?= =?iso-8859-1?Q?ULdQxdTx6KSnF99b+0U4MB1FeeRysbt59LlP8VIEx0xBtoIFqwasxsonjj?= =?iso-8859-1?Q?93DVlIjAPGOhihrpy5vl3A3?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2129;5:bsrM7hCCYm2gUIBSTXUNZiu6pAYVb3N+w2nMfOLS15KRBkWon7HcO6WyXKBqU46DZwzg+zm+D5R+LF8f4f8TNWq8m6O/POzymCZNWlWYnnoQy+nSSpTjvAsLNNegwseSuiZxBkkLcjKf6AdG9GUprA==;24:3l33iZERVKSi4zEhEtBlblQtAXpUEkovtV7/u6oRIz6dZuVjUOMSns8yc7WdjlHHpHwhSeKd9Bx8rvxw5PQcoiFxXZdoc11UqJXQrU9C6QI=;20:zOxUClb5AC3ezuYvvHTl1E7UYx7kxviu/dDkxGAmefQ4rxYrDrf9il1Rvzh0HDGW0GaX1gXn4lKo2AdluWGOHw== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2015 21:04:03.6676 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2129 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/14/2015 01:58 PM, Arnd Bergmann wrote: > On Wednesday 14 October 2015 08:47:44 David Daney wrote: >> On 10/14/2015 07:06 AM, Sakshi Bansal wrote: >>> Fixed allignment issues and line over 80 characters >> >> Use spell checking on 'allignment' >> >> But that is not the main problem with the patch... >> >> >> You are changing things other than white space and comment formatting, >> can you tell us on which platforms the patch was tested to verify that >> you didn't break anything? > > In general a good advice, but for trivial whitespace or comment > changes, this is normally not necessary. Compile-testing a patch > as you say is normally expected, if only to avoid embarrassing > complaints if it does break later. > > For drivers that are not enabled in the x86 allmodconfig, it sure > helps to say something like "Compile-tested using MIPS cross toolchain > from https://www.kernel.org/pub/tools/crosstool/". Even better would > be to send a fix to decouple the driver from asm/octeon/*.h > to make it build on all architectures, but that is much more work > than I'd expect for a trivial patch. There is no point in such a patch. We know, a priori, that there will *never* be a non-MIPS system with this hardware. David Daney