From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754174AbbJNVUc (ORCPT ); Wed, 14 Oct 2015 17:20:32 -0400 Received: from mail-ob0-f179.google.com ([209.85.214.179]:36633 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752506AbbJNVUb (ORCPT ); Wed, 14 Oct 2015 17:20:31 -0400 Subject: Re: [PATCH v2 2/3] vTPM: reformat event log to be byte-aligned To: "Hon Ching(Vicky) Lo" References: <1444263114-15081-1-git-send-email-honclo@linux.vnet.ibm.com> <1444263114-15081-3-git-send-email-honclo@linux.vnet.ibm.com> <561D50DA.9090605@gmail.com> <1444771677.16434.0.camel@vtpm2014.ibm.com> <561EC5DB.4030300@gmail.com> Cc: tpmdd-devel@lists.sourceforge.net, Peter Huewe , Ashley Lai , Mimi Zohar , Vicky Lo , linux-kernel@vger.kernel.org From: Ashley Lai Message-ID: <561EC71C.2090609@gmail.com> Date: Wed, 14 Oct 2015 16:20:28 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <561EC5DB.4030300@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/14/2015 04:15 PM, Ashley Lai wrote: > > > On 10/13/2015 04:27 PM, Hon Ching(Vicky) Lo wrote: >> On Tue, 2015-10-13 at 13:43 -0500, Ashley Lai wrote: >>> On 10/07/2015 07:11 PM, Hon Ching(Vicky) Lo wrote: >>>> The event log generated by OpenFirmware in PowerPC is 4-byte aligned. >>>> This patch reformats the log to be byte-aligned for the Linux client. >>>> >>>> Signed-off-by: Hon Ching(Vicky) Lo >>>> --- >>>> arch/powerpc/kernel/prom_init.c | 13 ++++++++++++- >>>> 1 files changed, 12 insertions(+), 1 deletions(-) >>>> >>>> diff --git a/arch/powerpc/kernel/prom_init.c >>>> b/arch/powerpc/kernel/prom_init.c >>>> index b9b6bb1..8a5c248 100644 >>>> --- a/arch/powerpc/kernel/prom_init.c >>>> +++ b/arch/powerpc/kernel/prom_init.c >>>> @@ -1417,8 +1417,9 @@ static void __init prom_instantiate_sml(void) >>>> { >>>> phandle ibmvtpm_node; >>>> ihandle ibmvtpm_inst; >>>> - u32 entry = 0, size = 0; >>>> + u32 entry = 0, size = 0, succ = 0; >>>> u64 base; >>>> + __be32 val; >>>> prom_debug("prom_instantiate_sml: start...\n"); >>>> @@ -1433,6 +1434,16 @@ static void __init >>>> prom_instantiate_sml(void) >>>> return; >>>> } >>>> + if (prom_getprop(ibmvtpm_node, >>>> "ibm,sml-efi-reformat-supported", >>>> + &val, sizeof(val)) != PROM_ERROR) { >>>> + if (call_prom_ret("call-method", 2, 2, &succ, >>>> + ADDR("reformat-sml-to-efi-alignment"), >>>> + ibmvtpm_inst) != 0 || succ == 0) { >>> reformat-sml-to-efi-alignment is something new just added in the >>> firmware? I don't remember seeing it before. >> Yes, it's new. Our new firmware version will support it. > Looks like this will break the backward compatibility with the new > kernel running on the older firmware. Never mind. I missed the check before that. Looks good to me. > >> >>> >>>> >> >