Re: [RFC 3/4] x86/signal/64: Re-add support for SS in the 64-bit signal context

Stas Sergeev
2015-10-14T15:18:05Z

14.10.2015 18:01, Ingo Molnar пишет:
>
> * Stas Sergeev <stsp@list.ru> wrote:
>
>> On an off-topic: there was recently a patch from you that
>> disables vm86() by mmap_min_addr. I've found that dosemu, when
>> started as root, could override mmap_min_addr. I guess this will
>> no longer work, right? Not a big regression, just something to
>> know and document.
>
> So I think it should still work, because we check for mmap_min_addr in the system
> call itself:
>
> static long do_sys_vm86(struct vm86plus_struct __user *user_vm86, bool plus)
> {
> ...
> err = security_mmap_addr(0);
> if (err) {
> /*
>
> So if dosemu first tweaks mmap_min_addr, the syscall should succeed.
No, it doesn't tweak it.
It just seems that root is allowed to do mmap(0, MAP_FIXED)
_regardless_ of mmap_min_addr. But it would be crazy to run vm86() as
root to also bypass the check (dosemu drops privs earlier), so I guess
this trick will stop working.