From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932360AbbJNXbD (ORCPT ); Wed, 14 Oct 2015 19:31:03 -0400 Received: from lists.s-osg.org ([54.187.51.154]:56570 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753717AbbJNXbB (ORCPT ); Wed, 14 Oct 2015 19:31:01 -0400 Message-ID: <561EE5B1.40402@osg.samsung.com> Date: Thu, 15 Oct 2015 00:30:57 +0100 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: James Bottomley CC: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH] scsi: kconfig: When possible, compile drivers with COMPILE_TEST References: <1444857220-26595-1-git-send-email-luisbg@osg.samsung.com> <1444862561.2220.81.camel@HansenPartnership.com> In-Reply-To: <1444862561.2220.81.camel@HansenPartnership.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/10/15 23:42, James Bottomley wrote: > On Wed, 2015-10-14 at 22:13 +0100, Luis de Bethencourt wrote: >> These drivers only have runtime but no build time dependencies, so they can >> be built for testing purposes if the Kconfig COMPILE_TEST option is enabled. >> >> This is useful to have more build coverage and make sure that drivers are >> not affected by changes that could cause build regressions. > > I don't think I understand the purpose. If the object is to build a > load of old ISA drivers, why not just turn on CONFIG_ISA in the test > build? That's how I build test SCSI on my systems. > > James > > Hi James, The idea is that the more drivers are built with make allyesconfig, the better. I added COMPILE_TEST to all the drivers that can be built without having ISA, since they depend on runtime and not in build time. I understand your point, which raises the question of why isn't CONFIG_ISA set to Y in make allyesconfig. Would this be possible? Thanks for the review, Luis