From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754687AbbJNXbm (ORCPT ); Wed, 14 Oct 2015 19:31:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40017 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753772AbbJNXbl (ORCPT ); Wed, 14 Oct 2015 19:31:41 -0400 Subject: Re: drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c:70:2-8: preceding lock on line 67 To: Julia Lawall References: <201510141846.22W2v2Rw%fengguang.wu@intel.com> Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org From: Ben Skeggs Message-ID: <561EE5E0.6090309@redhat.com> Date: Thu, 15 Oct 2015 09:31:44 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wAx2cGrEgRLPD9WqXDxIFpEBgSkco0wie" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wAx2cGrEgRLPD9WqXDxIFpEBgSkco0wie Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 10/14/2015 10:30 PM, Julia Lawall wrote: > Please check whether not releasing the lock is intentional. It's intentional, there's a nvkm_fifo_chan_put() that releases it again, which should be used everywhere a successful acquire has occurred. Ben. >=20 > julia >=20 > On Wed, 14 Oct 2015, kbuild test robot wrote: >=20 >> CC: kbuild-all@01.org >> CC: linux-kernel@vger.kernel.org >> TO: Ben Skeggs >> >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux= =2Egit master >> head: 5b5f1455272e23f4e7889cec37228802d8d01adf >> commit: 344c2d429dd86b1b0113177e18f15adb74e9d936 drm/nouveau/fb: remov= e dependence on namedb/engctx lookup >> date: 7 weeks ago >> :::::: branch date: 16 hours ago >> :::::: commit date: 7 weeks ago >> >>>> drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c:70:2-8: preceding lo= ck on line 67 >> >> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/t= orvalds/linux.git >> git remote update linus >> git checkout 344c2d429dd86b1b0113177e18f15adb74e9d936 >> vim +70 drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c >> >> 344c2d42 Ben Skeggs 2015-08-20 61 } >> 344c2d42 Ben Skeggs 2015-08-20 62 >> 344c2d42 Ben Skeggs 2015-08-20 63 struct nvkm_fifo_chan * >> 344c2d42 Ben Skeggs 2015-08-20 64 nvkm_fifo_chan_chid(struct nvkm_fi= fo *fifo, int chid, unsigned long *rflags) >> 344c2d42 Ben Skeggs 2015-08-20 65 { >> 344c2d42 Ben Skeggs 2015-08-20 66 unsigned long flags; >> 344c2d42 Ben Skeggs 2015-08-20 @67 spin_lock_irqsave(&fifo->lock, fl= ags); >> 344c2d42 Ben Skeggs 2015-08-20 68 if (fifo->channel[chid]) { >> 344c2d42 Ben Skeggs 2015-08-20 69 *rflags =3D flags; >> 344c2d42 Ben Skeggs 2015-08-20 @70 return (void *)fifo->channel[chi= d]; >> 344c2d42 Ben Skeggs 2015-08-20 71 } >> 344c2d42 Ben Skeggs 2015-08-20 72 spin_unlock_irqrestore(&fifo->loc= k, flags); >> 344c2d42 Ben Skeggs 2015-08-20 73 return NULL; >> >> --- >> 0-DAY kernel test infrastructure Open Source Technology= Center >> https://lists.01.org/pipermail/kbuild-all Intel Corp= oration >> --wAx2cGrEgRLPD9WqXDxIFpEBgSkco0wie Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWHuXoAAoJEHYLnGJQkpH7UsAP/Rw/c67Hgo4ED6uCLvQFP3Um ko02zsPZv1d7JmulI3wuxlTTdJpBCPpBJTWKa0xfzSdBD4BSHl9YWxJhpRVS7dBf hUsTkHWh108JjJ/yLz3zeoxydApYJtKTUw/Jg8LGI0OjJZE+PABQNbxwtOHSpxUu 1DPcL0g3RRuwO4bK9PpdftNqP6Dpeqre/z5O1vVPUypJmxhjrC2gWsrHwmVs3pW7 8aeYzWMABeSP3xF4UBlqzxe9yOjBxgNF1ql9k3hlsskPo52Yq8igiWNEzBzMqwgJ dW9T1JPcDFg6hXAdQm2fPRLjI+4VuKFW9hB2F4FmxIhE0IyPvD0eXw/o3T0Y3LfD sPjG7pscuYX84iev++WKFaNrGYdpskbP3JLFsplHwUAIkiqs4OscomdIaBPwvWwc YibJiHT6+laFxRRH/b9AkZveJjlqz+7TK0wcz/46OALvDoZMFRjj1l6FfCixPGIM TDIBo5nHk7qPFO3FAeucfz89CsJkexQpbwGPgy/VtrY71Q8N76QIVjxOlxqbhapr 8hFI69IAGwT+cOcboyWC9p0+PgxolersjyienuM4RUJlWhiwZd6QK/qq4ZIanag2 YL3FLv/mQa+SEArRzbyIOfjY0x+ave5i1fiTii3nKpVUMEdoQeZtNOCU5rXrH3Eu McE4KzdtPNDYAoHEwDAy =eWX5 -----END PGP SIGNATURE----- --wAx2cGrEgRLPD9WqXDxIFpEBgSkco0wie--