From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752092AbbJOIjV (ORCPT ); Thu, 15 Oct 2015 04:39:21 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:60990 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751452AbbJOIjP (ORCPT ); Thu, 15 Oct 2015 04:39:15 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee690-f794e6d0000014de-f2-561f6631ae2f Content-transfer-encoding: 8BIT Message-id: <561F6630.3050802@samsung.com> Date: Thu, 15 Oct 2015 17:39:12 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Charles Keepax , broonie@kernel.org, lee.jones@linaro.org Cc: myungjoo.ham@samsung.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH 1/3] extcon: arizona: Add extcon specific device tree binding document References: <1444831944-4655-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1444831944-4655-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> In-reply-to: <1444831944-4655-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDIsWRmVeSWpSXmKPExsWyRsSkQNcwTT7MoH2dmMXUh0/YLP5NucFu Mf/IOVaL+1+PMlp8u9LBZHF51xw2i9uNK9gslr/9z+bA4bFz1l12j02rOtk87lzbw+bxcuJv No++LasYPT5vkgtgi+KySUnNySxLLdK3S+DKWHV7E3PBH/6Ke32LWRoYW3m7GDk5JARMJD5d usUCYYtJXLi3nq2LkYtDSGAFo8T/d//YYIomNM9khEjMYpT4feAKWIJXQFDix+R7QN0cHMwC 8hJHLmWDhJkF1CUmzVvEDGILCTxglLj2lB+iXEti5rPVYK0sAqoSi1+fBLPZgOL7X9xgAxkj KhAh0X2iEiQsIpAi8exSPyvIWmaBSYwSv7bPB6sXFoiR6Dv1jQXinrlA90zoYgJJcAqESsxp vAqWkBB4yS4xc+IRVohtAhLfJh8CO1RCQFZi0wFmiMckJQ6uuMEygVFsFpJ3ZiG8MwvJOwsY mVcxiqYWJBcUJ6UXmegVJ+YWl+al6yXn525iBEbi6X/PJuxgvHfA+hCjAAejEg/viQdyYUKs iWXFlbmHGE2BjpjILCWanA+M97ySeENjMyMLUxNTYyNzSzMlcd7XUj+DhQTSE0tSs1NTC1KL 4otKc1KLDzEycXBKNTAm+d6p29z695/WL/a2i7niga+XRbsbNmxe4Rppq51UtGPaiszCLyq3 OMzMW4QuePDYb4iQu9cuqBFk2L82dIWcpeKa6ByLbdbL91/7s1k2rGFT5ckHDIGHjRJu8CiL Lp/NOvWUmkvbv+qg1lvfKs/4xa2bc9dL4t6is0/vnkqZcvueW8KzOj0lluKMREMt5qLiRADv BVhMvwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJIsWRmVeSWpSXmKPExsVy+t9jQV3DNPkwg/bNAhZTHz5hs/g35Qa7 xfwj51gt7n89ymjx7UoHk8XlXXPYLG43rmCzWP72P5sDh8fOWXfZPTat6mTzuHNtD5vHy4m/ 2Tz6tqxi9Pi8SS6ALaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfV VsnFJ0DXLTMH6CIlhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGENY8aq25uY C/7wV9zrW8zSwNjK28XIySEhYCIxoXkmI4QtJnHh3nq2LkYuDiGBWYwSvw9cYQNJ8AoISvyY fI+li5GDg1lAXuLIpWyQMLOAusSkeYuYQWwhgQeMEtee8kOUa0nMfLYarJVFQFVi8euTYDYb UHz/ixtsIGNEBSIkuk9UgoRFBFIknl3qZwVZyywwiVHi1/b5YPXCAjESfae+sUDcMxfongld TCAJToFQiTmNV1kmMAJdiXDeLITzZiE5bwEj8ypGidSC5ILipPRco7zUcr3ixNzi0rx0veT8 3E2M4Gh/Jr2D8fAu90OMAhyMSjy8Jx7IhQmxJpYVV+YeYpTgYFYS4fWIkw8T4k1JrKxKLcqP LyrNSS0+xGgK9OBEZinR5HxgIsoriTc0NjEzsjQyN7QwMjZXEue9cYghTEggPbEkNTs1tSC1 CKaPiYNTqoFRnXkWh/2n8vSq8LLylFPWXl++KsySOnTg08l/l4zzVkemn9nczfFi3tpT3E+a Z6psOvVZyzliduY3/+Kjuw1btfOucCZcbUv4enL7vEuf585zdKp8t4KJ6ciapIB7tQk8u1+J +mytMzzcVtNy9vuF+5yvW5tr6zcol6lrnG//tffW8w8fOmbLKrEUZyQaajEXFScCAO+Hd8YM AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Charles, On 2015년 10월 14일 23:12, Charles Keepax wrote: > Signed-off-by: Charles Keepax > --- > .../devicetree/bindings/extcon/extcon-arizona.txt | 15 +++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 16 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/extcon/extcon-arizona.txt > > diff --git a/Documentation/devicetree/bindings/extcon/extcon-arizona.txt b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt > new file mode 100644 > index 0000000..e1705fa > --- /dev/null > +++ b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt > @@ -0,0 +1,15 @@ > +Cirrus Logic Arizona class audio SoCs > + > +These devices are audio SoCs with extensive digital capabilities and a range > +of analogue I/O. > + > +This document lists Extcon specific bindings, see the primary binding document: > + ../mfd/arizona.txt > + > +Optional properties: > + > + - wlf,hpdet-channel : Headphone detection channel. > + ARIZONA_ACCDET_MODE_HPL or 1 - Headphone detect mode is set to HPDETL > + ARIZONA_ACCDET_MODE_HPR or 2 - Headphone detect mode is set to HPDETR > + If this node is not mentioned or if the value is unknown, then > + headphone detection mode is set to HPDETL. > diff --git a/MAINTAINERS b/MAINTAINERS > index 9f6685f..08c804a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11393,6 +11393,7 @@ T: git https://github.com/CirrusLogic/linux-drivers.git > W: https://github.com/CirrusLogic/linux-drivers/wiki > S: Supported > F: Documentation/hwmon/wm83?? > +F: Documentation/devicetree/bindings/extcon/extcon-arizona.txt > F: arch/arm/mach-s3c64xx/mach-crag6410* > F: drivers/clk/clk-wm83*.c > F: drivers/extcon/extcon-arizona.c > You should add the description of patch. If you add the description, looks good to me and you can add my acked tag. Acked-by: Chanwoo Choi Thanks, Chanwoo Choi