From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752649AbbJOJqA (ORCPT ); Thu, 15 Oct 2015 05:46:00 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:56371 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752315AbbJOJp4 convert rfc822-to-8bit (ORCPT ); Thu, 15 Oct 2015 05:45:56 -0400 Subject: Re: [PATCHv3 08/11] arm64: Check for selected granule support To: Mark Rutland References: <1444821634-1689-1-git-send-email-suzuki.poulose@arm.com> <1444821634-1689-9-git-send-email-suzuki.poulose@arm.com> <20151014172418.GI5041@leverpostej> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, steve.capper@linaro.org, marc.zyngier@arm.com, ard.biesheuvel@linaro.org, christoffer.dall@linaro.org From: "Suzuki K. Poulose" Message-ID: <561F75D2.8010301@arm.com> Date: Thu, 15 Oct 2015 10:45:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20151014172418.GI5041@leverpostej> X-OriginalArrivalTime: 15 Oct 2015 09:45:54.0273 (UTC) FILETIME=[48DC1D10:01D1072E] X-MC-Unique: sTf-RBIKQ6-ekfOYM7ybSQ-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/10/15 18:24, Mark Rutland wrote: >> - * other registers depend on the function called upon completion >> + * Other registers depend on the function called upon completion. >> + * >> + * Checks if the selected granule size is supported by the CPU. >> + * If it doesn't park the CPU > > Nit: "If it isn't, park the CPU." OK > >> */ >> +#if defined(CONFIG_ARM64_64K_PAGES) >> + >> +#define id_aa64mmfr0_tgran_shift ID_AA64MMFR0_TGRAN64_SHIFT >> +#define id_aa64mmfr0_tgran_on ID_AA64MMFR0_TGRAN64_ON >> + >> +#else >> + >> +#define id_aa64mmfr0_tgran_shift ID_AA64MMFR0_TGRAN4_SHIFT >> +#define id_aa64mmfr0_tgran_on ID_AA64MMFR0_TGRAN4_ON > > Any reason for not using upper-case names for the macros? Nothing in particular. I had them in upper-case in the previous version, changed it here ;) for absolutely no reason. I could switch it back. > Given they're local you could just call them TGRAN_SHIFT and TRGRAN_ON > to make the asm slightly nicer. Given Jeremy's suggestion to add something to the EFI stub, I will retain the original definition with all upper-case and define it somewhere in a header so that we can reuse it. >> + >> +__no_granule_support: >> + wfe >> + b __no_granule_support >> +ENDPROC(__no_granule_support) > > Other than the above, this loogs fine to me. > > In future it would be nice if we could somehow signal that these dead > CPUs are trapped in the kernel -- we should have some kind of canary > mechanism for that. That needn't block this patch, though. Yes, we should. Thanks for the review Suzuki