From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753394AbbJOMO7 (ORCPT ); Thu, 15 Oct 2015 08:14:59 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:37339 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752183AbbJOMOz (ORCPT ); Thu, 15 Oct 2015 08:14:55 -0400 Subject: Re: [PATCH v5] extcon: Modify the id and name of external connector To: Chanwoo Choi , References: <1444900712-3832-1-git-send-email-cw00.choi@samsung.com> CC: , , , , , From: Roger Quadros Message-ID: <561F98B1.5000606@ti.com> Date: Thu, 15 Oct 2015 15:14:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1444900712-3832-1-git-send-email-cw00.choi@samsung.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/10/15 12:18, Chanwoo Choi wrote: > This patch modifies the id and name of external connector with the > additional prefix to clarify both attribute and meaning of external > connector as following: > - EXTCON_CHG_* mean the charger connector. > - EXTCON_JACK_* mean the jack connector. > - EXTCON_DISP_* mean the display port connector. > > Following table show the new name of external connector with old name: > -------------------------------------------------- > Old extcon name | New extcon name | > -------------------------------------------------- > EXTCON_TA | EXTCON_CHG_USB_DCP | > EXTCON_CHARGE_DOWNSTREAM| EXTCON_CHG_USB_CDP | > EXTCON_FAST_CHARGER | EXTCON_CHG_USB_FAST | > EXTCON_SLOW_CHARGER | EXTCON_CHG_USB_SLOW | > -------------------------------------------------- > EXTCON_MICROPHONE | EXTCON_JACK_MICROPHONE | > EXTCON_HEADPHONE | EXTCON_JACK_HEADPHONE | > EXTCON_LINE_IN | EXTCON_JACK_LINE_IN | > EXTCON_LINE_OUT | EXTCON_JACK_LINE_OUT | > EXTCON_VIDEO_IN | EXTCON_JACK_VIDEO_IN | > EXTCON_VIDEO_OUT | EXTCON_JACK_VIDEO_OUT | > EXTCON_SPDIF_IN | EXTCON_JACK_SPDIF_IN | > EXTCON_SPDIF_OUT | EXTCON_JACK_SPDIF_OUT | > -------------------------------------------------- > EXTCON_HMDI | EXTCON_DISP_HDMI | > EXTCON_MHL | EXTCON_DISP_MHL | > EXTCON_DVI | EXTCON_DISP_DVI | > EXTCON_VGA | EXTCON_DISP_VGA | > -------------------------------------------------- > > And, when altering the name of USB charger connector, EXTCON refers to the > "Battery Charging v1.2 Spec and Adopters Agreement"[1] to use the standard > name of USB charging port as following. Following name of USB charging port > are already used in power_supply subsystem. We chan check it on patch[2]. > - EXTCON_CHG_USB_SDP /* Standard Downstream Port */ > - EXTCON_CHG_USB_DCP /* Dedicated Charging Port */ > - EXTCON_CHG_USB_CDP /* Charging Downstream Port */ > - EXTCON_CHG_USB_ACA /* Accessory Charger Adapter */ > > [1] www.usb.org/developers/docs/devclass_docs/BCv1.2_070312.zip > [2] commit 85efc8a18ced ("power_supply: Add types for USB chargers") > > Signed-off-by: Chanwoo Choi > [ckeepax: For the Arizona changes] > Acked-by: Charles Keepax Reviewed-by: Roger Quadros cheers, -roger