From: Shuah Khan <shuahkh@osg.samsung.com>
To: Kees Cook <keescook@chromium.org>
Cc: AKASHI Takahiro <takahiro.akashi@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Andy Lutomirski <luto@amacapital.net>,
Will Drewry <wad@chromium.org>,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH v3] selftests/seccomp: build and pass on arm64
Date: Thu, 15 Oct 2015 08:07:59 -0600 [thread overview]
Message-ID: <561FB33F.5030906@osg.samsung.com> (raw)
In-Reply-To: <20151006193025.GA11826@www.outflux.net>
On 10/06/2015 01:30 PM, Kees Cook wrote:
> Changing arm64 syscalls is done via a specific register set, more like s390
> than like arm (specific ptrace call) and x86 (part of general registers).
> Since (restarting) poll doesn't exist on arm64, switch to using nanosleep
> for testing restart_syscall. And since it looks like the syscall ABI is
> inconsistent on arm-compat, so we must work around it (and document it) in
> the test.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> v3:
> - correctly set syscall number on native arm64.
> v2:
> - switch to nanosleep from a bad mix of poll and ppoll for testing restart.
> ---
Is this good to go? Failed to apply to linux-kselftest next.
If you can rebase and resend. I can get this into 4.4-rc1
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2015-10-15 14:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 19:30 [PATCH v3] selftests/seccomp: build and pass on arm64 Kees Cook
2015-10-15 14:07 ` Shuah Khan [this message]
2015-10-15 18:42 ` Kees Cook
2015-10-15 20:06 ` Shuah Khan
2015-10-15 22:07 ` Kees Cook
2015-10-15 23:00 ` Shuah Khan
2015-10-15 23:01 ` Shuah Khan
2015-10-15 23:02 ` Kees Cook
2015-10-16 2:09 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561FB33F.5030906@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=arnd@arndb.de \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=takahiro.akashi@linaro.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox