From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753456AbbJOOme (ORCPT ); Thu, 15 Oct 2015 10:42:34 -0400 Received: from lists.s-osg.org ([54.187.51.154]:57920 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753147AbbJOOmd (ORCPT ); Thu, 15 Oct 2015 10:42:33 -0400 Subject: Re: [RFT PATCH 3/3] ARM: dts: Mark SDIO as non-removable in exynos5250-snow-common To: Tomeu Vizoso References: <1444906530-25048-1-git-send-email-javier@osg.samsung.com> <1444906530-25048-4-git-send-email-javier@osg.samsung.com> From: Javier Martinez Canillas X-Enigmail-Draft-Status: N1110 Cc: "linux-kernel@vger.kernel.org" , Krzysztof Kozlowski , Kukjin Kim , Douglas Anderson , Alim Akhtar , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc Message-ID: <561FBB53.8060302@osg.samsung.com> Date: Thu, 15 Oct 2015 16:42:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Tomeu, On 10/15/2015 02:30 PM, Tomeu Vizoso wrote: > On 15 October 2015 at 12:55, Javier Martinez Canillas > wrote: >> The Exynos5250 Snow Chromebooks have a Marvell WiFi SDIO chip which >> can't neither be removed nor be detected. But the node isn't marked >> as non-removable and instead has the broken-cd DT property. >> >> This causes the device to be removed when the system enters into a >> suspend state and the following warnings is shown after a resume: >> >> [ 181.944636] mmc2: error -2 during resume (card was removed?) > > Hi Javier, > > isn't wifi on snow on mmc_3? > Sigh, you are correct. It seems I have a really bad day and missed. I got confused though because the node for mmc_0 (eMMC) in Snow also has a broken-cd property instead of non-removable. I'll add another patch to the series changing that. I also noticed that the mmc_0 (eMMC) node in Peach boards have both non-removable and broken-cd which doesn't make sense and the MMC DT binding is clear that the options are mutually exclusive. Seems to be copy & paste error from the vendor tree since the downstream DTS also have both properties in the nodes. So I'll also add patches to remove the broken-cd from these nodes. > With your patch, I don't see any change, but if I do it on mmc_3 > instead, the machine fails to resume. Will try to get more info. > Yes, I wouldn't expect any changes since the patch is marking the eMMC as non-removable but I wonder why is causing a fail to resume. Are you sure the system is resuming without $SUBJECT? You mentioned in IRC that S2R was broken for Snow in linux-next. > Regards, > > Tomeu > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America