From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753556AbbJOPVR (ORCPT ); Thu, 15 Oct 2015 11:21:17 -0400 Received: from foss.arm.com ([217.140.101.70]:36591 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751222AbbJOPVP (ORCPT ); Thu, 15 Oct 2015 11:21:15 -0400 Subject: Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property References: <1444743164-17735-1-git-send-email-sudeep.holla@arm.com> Cc: Linus Walleij , Sudeep Holla , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Kevin Hilman , Olof Johansson , Simon Horman , Magnus Damm To: Arnd Bergmann From: Sudeep Holla Message-ID: <561FC467.8090701@arm.com> Date: Thu, 15 Oct 2015 16:21:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 15/10/15 15:57, Linus Walleij wrote: > On Tue, Oct 13, 2015 at 3:32 PM, Sudeep Holla wrote: > >> The keyboard driver for GPIO buttons(gpio-keys) checks for one of the >> two boolean properties to enable gpio buttons as wakeup source: >> 1. "wakeup-source" or >> 2. the legacy "gpio-key,wakeup" >> >> However juno, ste-snowball and emev2-kzm9d dts file have a undetected >> "wakeup" property to indicate the wakeup source. >> >> This patch fixes it by making use of "wakeup-source" property. >> >> Cc: Simon Horman >> Cc: Magnus Damm >> Cc: Linus Walleij >> Signed-off-by: Sudeep Holla > > OK nice, > Reviewed-by: Linus Walleij > Can you pick this up as fix for v4.3 with Ack from Simon and Linus Walleij ? I will repost 2/2 as a part of bigger cleanup for v4.4 -- Regards, Sudeep