From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753626AbbJOPoq (ORCPT ); Thu, 15 Oct 2015 11:44:46 -0400 Received: from foss.arm.com ([217.140.101.70]:36853 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753461AbbJOPoo (ORCPT ); Thu, 15 Oct 2015 11:44:44 -0400 Subject: Re: [PATCH v3 1/2] ACPI / tables: simplify acpi_parse_entries To: "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Rafael J. Wysocki" References: <1442408287-10410-1-git-send-email-sudeep.holla@arm.com> <1443712312-9176-1-git-send-email-sudeep.holla@arm.com> Cc: Sudeep Holla , Al Stone , Lorenzo Pieralisi From: Sudeep Holla Message-ID: <561FC9E9.20507@arm.com> Date: Thu, 15 Oct 2015 16:44:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1443712312-9176-1-git-send-email-sudeep.holla@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, On 01/10/15 16:11, Sudeep Holla wrote: > acpi_parse_entries passes the table end pointer to the sub-table entry > handler. acpi_parse_entries itself could validate the end of an entry > against the table end using the length in the sub-table entry. > > This patch adds the validation of the sub-table entry end using the > length field.This will help to eliminate the need to pass the table end > to the handlers. > > It also moves the check for zero length entry early so that execution of > the handler can be avoided. > > Cc: "Rafael J. Wysocki" Now that Al's MADT is queued, can you consider applying these ? -- Regards, Sudeep