From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753663AbbJOQBt (ORCPT ); Thu, 15 Oct 2015 12:01:49 -0400 Received: from foss.arm.com ([217.140.101.70]:36969 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753501AbbJOQBs (ORCPT ); Thu, 15 Oct 2015 12:01:48 -0400 Message-ID: <561FCDCA.1080804@arm.com> Date: Thu, 15 Oct 2015 17:01:14 +0100 From: James Morse User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Jungseok Lee CC: takahiro.akashi@linaro.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, barami97@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] arm64: Expand the stack trace feature to support IRQ stack References: <1444231692-32722-1-git-send-email-jungseoklee85@gmail.com> <1444231692-32722-3-git-send-email-jungseoklee85@gmail.com> <5617CE26.10604@arm.com> <179A25A2-C346-46C0-93D1-BABD4B6CB401@gmail.com> In-Reply-To: <179A25A2-C346-46C0-93D1-BABD4B6CB401@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/10/15 15:24, Jungseok Lee wrote: > On Oct 9, 2015, at 11:24 PM, James Morse wrote: >> I think unwind_frame() needs to walk the irq stack too. [2] is an example >> of perf tracing back to userspace, (and there are patches on the list to >> do/fix this), so we need to walk back to the start of the first stack for >> the perf accounting to be correct. > > I plan to do re-spin this series without [PATCH 2/2] since 1) Akashi's > approach looks better than mine and 2) you have the perf patches for [2]. They aren't my patches - the ones I saw on the list were for arm: https://lkml.org/lkml/2015/10/1/769 - its evidently something perf supports, so we shouldn't make it worse... Thanks! James