From: David Daney <ddaney@caviumnetworks.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sakshi Bansal <sakshi.april5@gmail.com>,
<devel@driverdev.osuosl.org>, <helen.fornazier@gmail.com>,
Paul Martin <paul.martin@codethink.co.uk>, <arnd@arndb.de>,
<david.daney@cavium.com>, <janne.huttunen@nokia.com>,
<gregkh@linuxfoundation.org>, <jtk54@cornell.edu>,
<linux-kernel@vger.kernel.org>, <ralf@linux-mips.org>,
<aaro.koskinen@nokia.com>, <jamie.lawler@gmail.com>,
<joe@perches.com>, <robertoxmed@gmail.com>,
<okash.khawaja@gmail.com>
Subject: Re: [PATCH] staging: octeon: fixed few coding style warnings
Date: Thu, 15 Oct 2015 09:58:31 -0700 [thread overview]
Message-ID: <561FDB37.3040602@caviumnetworks.com> (raw)
In-Reply-To: <20151015134030.GB7340@mwanda>
On 10/15/2015 06:40 AM, Dan Carpenter wrote:
> On Wed, Oct 14, 2015 at 09:09:04AM -0700, David Daney wrote:
>> and make sure you don't break the driver.
>
> I'm not seeing how this patch breaks anything? What am I missing?
Did you apply it and then compile the result? If not, then how can you
assert that it does not break anything?
From SubmitChecklist item #2: "Builds cleanly ..."
I don't want to waste time considering patches that don't, at a minimum,
meet this criterion. Other people may want to do the build testing, but
I prefer that the patch submitter at least vet the patch enough that
they can assert that it still builds cleanly.
David Daney
next prev parent reply other threads:[~2015-10-15 16:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 14:06 [PATCH] staging: octeon: fixed few coding style warnings Sakshi Bansal
2015-10-14 15:47 ` David Daney
[not found] ` <CAHqFf+uUJ4UjvVESkGf9Mqa000U0Ek7qEPwe8wZSvrY3XOzBvw@mail.gmail.com>
2015-10-14 15:57 ` David Daney
[not found] ` <CAHqFf+tUE6AhxRLPA89txFCUWSPDEVrYqCneA_jsDBgzGH+G_Q@mail.gmail.com>
2015-10-14 16:09 ` David Daney
2015-10-15 13:40 ` Dan Carpenter
2015-10-15 16:58 ` David Daney [this message]
2015-10-15 18:13 ` Dan Carpenter
2015-10-14 20:58 ` Arnd Bergmann
2015-10-14 21:04 ` David Daney
2015-10-14 21:32 ` Arnd Bergmann
2015-10-14 19:34 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561FDB37.3040602@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=aaro.koskinen@nokia.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@oracle.com \
--cc=david.daney@cavium.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=helen.fornazier@gmail.com \
--cc=jamie.lawler@gmail.com \
--cc=janne.huttunen@nokia.com \
--cc=joe@perches.com \
--cc=jtk54@cornell.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=okash.khawaja@gmail.com \
--cc=paul.martin@codethink.co.uk \
--cc=ralf@linux-mips.org \
--cc=robertoxmed@gmail.com \
--cc=sakshi.april5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox