From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752875AbbJOQ6l (ORCPT ); Thu, 15 Oct 2015 12:58:41 -0400 Received: from mail-bl2on0069.outbound.protection.outlook.com ([65.55.169.69]:23712 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751856AbbJOQ6j (ORCPT ); Thu, 15 Oct 2015 12:58:39 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@caviumnetworks.com; Message-ID: <561FDB37.3040602@caviumnetworks.com> Date: Thu, 15 Oct 2015 09:58:31 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Dan Carpenter CC: Sakshi Bansal , , , Paul Martin , , , , , , , , , , , , Subject: Re: [PATCH] staging: octeon: fixed few coding style warnings References: <20151014140637.GA23007@localhost.localdomain> <561E7920.2000903@caviumnetworks.com> <561E7B74.6010304@caviumnetworks.com> <561E7E20.3030609@caviumnetworks.com> <20151015134030.GB7340@mwanda> In-Reply-To: <20151015134030.GB7340@mwanda> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: BLUPR07CA093.namprd07.prod.outlook.com (25.160.24.48) To DM3PR07MB2137.namprd07.prod.outlook.com (25.164.4.143) X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2137;2:V8f3EjPsjsEucZIaVqv15hiCHeRlYxVAhyfFcGrbVEbohdtIk6G1krBa9q7ZwufxwyREX/KnQUagfCvpAcxxdF6wJZR7VWg9BFMducOEFbqhmkzZksDvpcZlS6/q6q5suhpsp/ZcDea3Pj6e+sU5KNpufQliE3h7WfemqJe0ekE=;3:dp7QGTYd77SjWyUR1ABpeuUxAunmFNz5Xn3s+XRuRhpmUF2FLeg5ElJsIbTrcLaxZc8CcTNck1vr62ievuwbSRWRTBNtZfU1OmkH78Z0T7P7VisQ3rPmuVTS6qXpxWLnH4JrWS5nmj+I5P7C2mHJOg==;25:K7rFxmhWnCkHTmQYZ/aq6IZj7AdqtM0JadDyHO/BAO30roy3NasZc0Mn3s0wvmGOXyqa9OQPnDj2PfRPbnuLqrB0Vp0pk5LzI1Lw9kR2lKZFOSqisfqVTG55h1HONeB16L0k0RWMsnX0AoTwIEwjuZfEkaq8zsWUzXKFdNyU9pQyQHtPtDHfTi/EKmYaXIagAuj4M06MjG0MUycmAkzT3mF614slplssPd/8VkgLaGQ8oZdJE8QMkw/x4okoZsWCHONv3wi43fCZDhgXjjXyAw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2137; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2137;20:WU4wHdzQpjCAmHfuXd+gr/i+U1cyJ1ekZ6z9329H20SkWcESWGJ4IFgf4WA4/7nuM5AWimeTQrAvaoU6Ml2XSttmuTxdq3iGqUEQeavkJ9it4t/a3aQHOtcezYJgVrrS6cgqOwlW30O4rPt8YxD0s4/H5DxTNuNleuYgHWcbhsAxiAVgw/CcDx877WaPndYjoRNIXgLevkYDxspZ3I/7jYFCHosFkB+fnuD3Nbqhv98n8vedS8vGb7pb/tRJN62H35FiL/odlcDhXBpUDL29g7Pq5wRa/pYwJvI5M5opUK73e2jNWTLdKtD5qn1a98KOiwvH3QExi9/V4cHDVOREBxbJn/60cOXCAK3R26y0n9f3EtUuKcLONElTmTXfKxHuuUXR5ltlrsFSYFm+o+5d3QpXODjiaGgYIE60exYm6AjeSRJcS0Hz+jeXafP/eMBYjFcmykAl3dd8R7VNT41zFRDxLCPOWYtsJS32D4rzC8ejI90mmWMP6DQqIzrwxI+rf/jJnXPf/CpXFVSU2olmuboiIjehRzODJPmSEjHNAj2FSd9u/e9vTEDoTPv9k/AEDGdllkOYdZEWpEr4/i8GJIXMTPNJvNMWWJpTPpzWlbk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001);SRVR:DM3PR07MB2137;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2137; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2137;4:8fLTJDm4+RxWBsNvjC0R9cVv/c9icmfkZ6sdx6zUodGqu8oujTSiWH0nmWmsm1w1eDqH9m8y9uobGT6rHPactDao+ZRVtXtsKGwWjh5uFPCyHdWE5REB33WdLV0lylr3ghfE3U31BVqao9ca7Ry26zbjxpN5kPCipHuiHyV9YvbQbjoRUekAPKIYGaOrWIQzCFaPg+piwduH9RLLwXwDeHyf9wfkiYJxdMtk0kjbQdCiVhRIpkVhIoPoZP6B68yfhmq4XQu6jkQ1hAe7JpcOhzzRk9WZZwzm11yjqopWj77iMMRMzD7244lMiyKKJnOjwWeTJ8XAsjEYiG32jUY2mWxCFyNRyLAtVa3mCCAXjl0= X-Forefront-PRVS: 0730093765 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(979002)(6009001)(189002)(377454003)(24454002)(199003)(479174004)(5008740100001)(64126003)(65816999)(65806001)(81156007)(5007970100001)(76176999)(42186005)(106356001)(40100003)(101416001)(4001350100001)(59896002)(77096005)(87266999)(122386002)(47776003)(5004730100002)(46102003)(93886004)(97736004)(50986999)(65956001)(54356999)(92566002)(36756003)(53416004)(80316001)(33656002)(23756003)(69596002)(87976001)(66066001)(2950100001)(64706001)(83506001)(50466002)(105586002)(189998001)(5001960100002)(110136002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR07MB2137;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;DM3PR07MB2137;23:j2mkZJci2snFYM7xd1N8wIj92I+kUYtEostMX0s?= =?iso-8859-1?Q?9owet9Y+yGW+lJUM0QPTp3jlqgCRvsn/c8stzC02aWWFyia0QFpG5el18z?= =?iso-8859-1?Q?O2L4c5H2OyQWxMybsSXdL7yP216sjv1lVy7P7YCzv+VQtWKJZgkMtXthPp?= =?iso-8859-1?Q?ml3f9xJz1+ndsJiXEHrP+LwO2mPWs/pDLYl5xta/qYKqoDoRivnz0oP/8/?= =?iso-8859-1?Q?t0dUOodj7X0lFtWAruAGOFOy+q5+dSfnuX6isx5hAEG2bBR6zjJsUYqqX5?= =?iso-8859-1?Q?/9+RMA55rUjtQy4N6PcQYbhab242QmxgAujaMnA9R0Yltx7m1BFJxBDucs?= =?iso-8859-1?Q?ATgL7Y9KTQK4F5swGKJfi+ON4pjzE08otJiJPETNGGRT/dEJ8aeaRMlnPq?= =?iso-8859-1?Q?GJqDa0xOcCqh8JbRuLhJZAeRNNXhFgnusTUk4xuznS0kavcTxCrhLBcsyD?= =?iso-8859-1?Q?D4qc7xjdmVwCM7MWdi4BUy0yLXwrXcrk7faNp5Q/04gNKmmP9gOg2XBVza?= =?iso-8859-1?Q?+1LX+uZeGrz0gUOK8IHGE667a/yp6vjCqnyezjWBVH3skER1W8p9p8pgeK?= =?iso-8859-1?Q?aZMBDP811V596CV2m128DRmX/FjWhF4mqV3f0ni9y4gbdVXAVxhHSBFw7+?= =?iso-8859-1?Q?xPbwkQ74uaLzuaqV2IqnU5J33OpDZ68PJKPbzJJbjdFmYDuaj0t23yju+B?= =?iso-8859-1?Q?TV2FMZ5SH5XUrIcHsFGldRIFhmM+hwAMmAwyZKcC8WDA48316M9NKktXP6?= =?iso-8859-1?Q?NNmC+FnMpCyuq4OmIeob/FK+voP/QyRII31wGi89ZyUPwQjKefbavI8e/4?= =?iso-8859-1?Q?XPmGE7U9YrBYnhZ7hg9CPY3xUkHeYCpPjl1uyPg2agW9Zrj3XyBh5wvBYE?= =?iso-8859-1?Q?FyvBrB4Rldc03KbqkqPVkGpbgYHrC4FqyxZ/v/IA8nB98rKw7ugN5CZL3B?= =?iso-8859-1?Q?qEvFWUxYUW5m8tXHPA32SYvMxySTM5VrDOkQY6W/2yOeQao8oL9WuivCqm?= =?iso-8859-1?Q?K8OtGHMGcPlQKvL2es+I8RpLgmRInOQKkSvf/pnPrD2ytGBeuS4GzCU8Uq?= =?iso-8859-1?Q?A/5vHcfn6apCAr/R3TD99iMY2xphX2NG34Gm+V2pybg8B9ZctNca4DMO0P?= =?iso-8859-1?Q?Nh+Iw6JrB6Hmg1s9pISGJFTqIdszP9yXo57U/xVwbYUP2W7+HdpdHPtbvp?= =?iso-8859-1?Q?2L67PWZjTxaUjHzC6ekCmLGooUqALG5oHgXyLmrCl9cV5BgCKdndR4DMiP?= =?iso-8859-1?Q?MPSIN/dndIoMUFGnJFmoAZ+YXDe/Q5hJyQIiuL6o9BrHi25nMe8KzeHEAC?= =?iso-8859-1?Q?nBImPD4OPxCKS/hNj9KifiNNiRmiHYz1ScAQXZUPLP3RmktqIdJE179wOT?= =?iso-8859-1?Q?CbFEWiZ6QOO/0yqsmJm3gTWtwD8ds?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2137;5:LsJh/dWSLmLbM/eilyX5YYZDJoxu8szTtz8KRwXiIOhW1TapBFz2Zdnk439j1EZ19pT7k7jLy2Oa09hAClmKKU++n2BJmfIfz10SXsnCpYP9Ls9QoFCb2qd0jp/FkIb8EDIksULdG0mn2QwC5oc2Jw==;24:FnvBZziz8Px31RxhKMf4KxqNlQCYJJFOuwuvXbEsF4hDIOTB//91KUD1WUOQEFIf1Q9Bj0ySWvjlxc9suni0B8b+Vpd+GiTxCNLNPpgaOCo=;20:QNp5F3OAAYYMlO2/1Tfx/IBl8cMylY3LOQyVZqRjcihdXiHcIibcX7Vucv6zXTSZFNlgoNGfI7cLi5BsDkazUQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2015 16:58:34.6464 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR07MB2137 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/15/2015 06:40 AM, Dan Carpenter wrote: > On Wed, Oct 14, 2015 at 09:09:04AM -0700, David Daney wrote: >> and make sure you don't break the driver. > > I'm not seeing how this patch breaks anything? What am I missing? Did you apply it and then compile the result? If not, then how can you assert that it does not break anything? From SubmitChecklist item #2: "Builds cleanly ..." I don't want to waste time considering patches that don't, at a minimum, meet this criterion. Other people may want to do the build testing, but I prefer that the patch submitter at least vet the patch enough that they can assert that it still builds cleanly. David Daney