From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753458AbbJORkA (ORCPT <rfc822;w@1wt.eu>);
	Thu, 15 Oct 2015 13:40:00 -0400
Received: from mail-pa0-f42.google.com ([209.85.220.42]:34136 "EHLO
	mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752124AbbJORj5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 15 Oct 2015 13:39:57 -0400
Message-ID: <561FE4CE.2030101@gmail.com>
Date: Thu, 15 Oct 2015 10:39:26 -0700
From: Florian Fainelli <f.fainelli@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Arun Parameswaran <arunp@broadcom.com>,
        "David S . Miller" <davem@davemloft.net>
CC: netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v2 1/1] net: phy: bcm-phy-lib: Fix module license issue
References: <1444930633-23314-1-git-send-email-arunp@broadcom.com> <1444930633-23314-2-git-send-email-arunp@broadcom.com>
In-Reply-To: <1444930633-23314-2-git-send-email-arunp@broadcom.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 15/10/15 10:37, Arun Parameswaran wrote:
> The 'bcm-phy-lib.c', added as a part of the commit
> "net: phy: Add Broadcom phy library for common interfaces"
> was missing the module license. This was causing an issue
> when the library is built as a module; "module license
> 'unspecified' taints kernel".
> 
> This patch fixes the issue by adding the module license,
> author and description to the bcm-phy-lib.c file.
> 
> Fixes: a1cba5613edf5 ("net: phy: Add Broadcom phy library for
> common interfaces")

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

> Signed-off-by: Arun Parameswaran <arunp@broadcom.com>
> ---
>  drivers/net/phy/bcm-phy-lib.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/phy/bcm-phy-lib.c b/drivers/net/phy/bcm-phy-lib.c
> index dd79ea6..ddb377e 100644
> --- a/drivers/net/phy/bcm-phy-lib.c
> +++ b/drivers/net/phy/bcm-phy-lib.c
> @@ -15,6 +15,7 @@
>  #include <linux/brcmphy.h>
>  #include <linux/export.h>
>  #include <linux/mdio.h>
> +#include <linux/module.h>
>  #include <linux/phy.h>
> 
>  #define MII_BCM_CHANNEL_WIDTH     0x2000
> @@ -206,3 +207,7 @@ int bcm_phy_enable_eee(struct phy_device *phydev)
>  	return 0;
>  }
>  EXPORT_SYMBOL_GPL(bcm_phy_enable_eee);
> +
> +MODULE_DESCRIPTION("Broadcom PHY Library");
> +MODULE_LICENSE("GPL v2");
> +MODULE_AUTHOR("Broadcom Corporation");
> --
> 2.6.1
> 


-- 
Florian