Re: [PATCH] xen: check return value of xenbus_printf

Dmitry Torokhov
2015-10-16T00:01:29Z

Hi Insu,

On Thu, Oct 15, 2015 at 06:40:12PM +0000, Insu Yun wrote:
> Signed-off-by: Insu Yun <wuninsu@gmail.com>

It looks lik eyou lost your patch description when respinning.

Thanks.

> ---
> drivers/input/misc/xen-kbdfront.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
> index 23d0549..9d465d7 100644
> --- a/drivers/input/misc/xen-kbdfront.c
> +++ b/drivers/input/misc/xen-kbdfront.c
> @@ -129,8 +129,14 @@ static int xenkbd_probe(struct xenbus_device *dev,
>
> if (xenbus_scanf(XBT_NIL, dev->otherend, "feature-abs-pointer", "%d", &abs) < 0)
> abs = 0;
> - if (abs)
> - xenbus_printf(XBT_NIL, dev->nodename, "request-abs-pointer", "1");
> + if (abs) {
> + ret = xenbus_printf(XBT_NIL, dev->nodename,
> + "request-abs-pointer", "1");
> + if (ret) {
> + pr_warning("xenkbd: can't request abs-pointer");
> + abs = 0;
> + }
> + }
>
> /* keyboard */
> kbd = input_allocate_device();
> --
> 1.9.1
>

--
Dmitry