From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752263AbbJPCJb (ORCPT ); Thu, 15 Oct 2015 22:09:31 -0400 Received: from lists.s-osg.org ([54.187.51.154]:60314 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751642AbbJPCJ3 (ORCPT ); Thu, 15 Oct 2015 22:09:29 -0400 Subject: Re: [PATCH v3] selftests/seccomp: build and pass on arm64 To: Kees Cook References: <20151006193025.GA11826@www.outflux.net> <561FB33F.5030906@osg.samsung.com> <56200761.8050607@osg.samsung.com> <56203023.2060007@osg.samsung.com> <5620304C.3070701@osg.samsung.com> Cc: AKASHI Takahiro , Arnd Bergmann , Andy Lutomirski , Will Drewry , Linux API , LKML , Shuah Khan From: Shuah Khan Organization: Samsung Open Source Group Message-ID: <56205C57.3070406@osg.samsung.com> Date: Thu, 15 Oct 2015 20:09:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/15/2015 05:02 PM, Kees Cook wrote: > On Thu, Oct 15, 2015 at 4:01 PM, Shuah Khan wrote: >> On 10/15/2015 05:00 PM, Shuah Khan wrote: >>> On 10/15/2015 04:07 PM, Kees Cook wrote: >>>> On Thu, Oct 15, 2015 at 1:06 PM, Shuah Khan wrote: >>>>> On 10/15/2015 12:42 PM, Kees Cook wrote: >>>>>> On Thu, Oct 15, 2015 at 7:07 AM, Shuah Khan wrote: >>>>>>> On 10/06/2015 01:30 PM, Kees Cook wrote: >>>>>>>> Changing arm64 syscalls is done via a specific register set, more like s390 >>>>>>>> than like arm (specific ptrace call) and x86 (part of general registers). >>>>>>>> Since (restarting) poll doesn't exist on arm64, switch to using nanosleep >>>>>>>> for testing restart_syscall. And since it looks like the syscall ABI is >>>>>>>> inconsistent on arm-compat, so we must work around it (and document it) in >>>>>>>> the test. >>>>>>>> >>>>>>>> Signed-off-by: Kees Cook >>>>>>>> --- >>>>>>>> v3: >>>>>>>> - correctly set syscall number on native arm64. >>>>>>>> v2: >>>>>>>> - switch to nanosleep from a bad mix of poll and ppoll for testing restart. >>>>>>>> --- >>>>>>> >>>>>>> Is this good to go? Failed to apply to linux-kselftest next. >>>>>>> If you can rebase and resend. I can get this into 4.4-rc1 >>>>>> >>>>>> Yes please. :) >>>>>> >>>>> >>>>> ok. Please rebase to linux-kselftest next and resend the patch. >>>> >>>> Am I looking at the right tree? linux-kselftest#next doesn't appear to >>>> have the s390 patch that was included in 4.3. >>>> >>> >>> I see what happened. Your patch is linux-next fixes and that went into >>> 4.3-rc2. I can get linux-next rebase to 4.3-rc2 and get your patch in. >>> Thanks for clearing this up. >> >> oops rebase linux-kselftest next i.e > > Okay, cool. Let me know if I need to do anything more. :) > Applied to linux-ksefltest next for 4.4-rc1 thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978