Re: [PATCH] Fix migration of SCHED_DEADLINE tasks

Luca Abeni
2015-10-15T20:10:18Z

Hi Juri,

On Thu, 15 Oct 2015 17:40:19 +0100
Juri Lelli <juri.lelli@arm.com> wrote:
> On 15/10/15 12:09, Luca Abeni wrote:
> > Commit 9d5142624256 ("sched/deadline: Reduce rq lock contention by
> > eliminating locking of non-feasible target") broke
[...]
> > cpu_rq(target)->dl.earliest_dl.curr))
> > + (dl_time_before(p->dl.deadline,
> > +
> > cpu_rq(target)->dl.earliest_dl.curr) ||
> > +
> > (cpu_rq(target)->dl.earliest_dl.curr == 0)))
>
> Can't we actually use dl.dl_nr_running here and below, so
> that we won't incur any wraparound problem?
I copied the "earliest_dl.curr == 0" check from inc_dl_deadline():
if (dl_rq->earliest_dl.curr == 0 ||
dl_time_before(deadline, dl_rq->earliest_dl.curr)) {
/*
* If the dl_rq had no -deadline tasks, or if the new
task
* has shorter deadline than the current one on dl_rq,
...

And init_dl_rq() has a comment saying "zero means no -deadline tasks"...
But now I see what you mean: actually, find_lock_later_rq() contains
the correct version of the check few lines below the wrong check (after
acquiring the rq lock).

Tomorrow I'll try the version of the check with
later_rq->dl.dl_nr_running, and if it works I'll send an updated patch.

Thanks,
Luca