From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932259AbbJPNFf (ORCPT ); Fri, 16 Oct 2015 09:05:35 -0400 Received: from lists.s-osg.org ([54.187.51.154]:32922 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932206AbbJPNFc (ORCPT ); Fri, 16 Oct 2015 09:05:32 -0400 Message-ID: <5620F616.1000501@osg.samsung.com> Date: Fri, 16 Oct 2015 14:05:26 +0100 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Krzysztof Kozlowski CC: linux-kernel@vger.kernel.org, Guenter Roeck , linux-watchdog@vger.kernel.org, wim@iguana.be, javier@osg.samsung.com Subject: Re: [PATCH v2] watchdog: Compile possible drivers with COMPILE_TEST References: <1444848906-19187-1-git-send-email-luisbg@osg.samsung.com> <561ECA86.2050100@roeck-us.net> <561ED31C.7090605@osg.samsung.com> <561ED9E6.8070600@roeck-us.net> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/10/15 03:11, Krzysztof Kozlowski wrote: > 2015-10-15 7:40 GMT+09:00 Guenter Roeck : >> On 10/14/2015 03:11 PM, Luis de Bethencourt wrote: >>> >>> On 14/10/15 22:35, Guenter Roeck wrote: >>>> >>>> On 10/14/2015 11:55 AM, Luis de Bethencourt wrote: >>>>> >>>>> These drivers have depends that aren't build dependencies, so it's >>>>> a good idea to allow these drivers to always be built when the >>>>> COMPILE_TEST option is enabled. >>>>> >>>>> That way, the drivers can be built with a config generated by make >>>>> allyesconfig and check if a patch would break the build. >>>>> >>>>> Signed-off-by: Luis de Bethencourt >>>> >>>> >>>> What architectures have you actually tested this for ? >>>> >>>> Guenter >>>> >>> >>> I've compiled it in x86 and then I tried ARM >>> (with CROSS_COMPILE="ccache arm-linux-gnueabihf-" ARCH=arm) >>> >>> But ARM kept failing due to other drivers, first Lustre then an Ethernet >>> driver (I40E), and more. >>> >> arm:allmodconfig should build fine. Either case, you can always run "make >> -i" >> to ignore errors, to ensure that you at least don't introduce new problems. >> >>> Is there a better way of doing this? >>> >> Sure, at least run allmodconfig for _all_ architectures, or at least >> for the major architectures. > > At least 32-bit and 64-bit of mixtures. x86 and ARMv7 is not enough. > For example something like: > $ apt-get install build-essential gcc-4.8-multilib > gcc-arm-linux-gnueabi gcc-aarch64-linux-gnu libc6-dev-arm64-cross > gcc-powerpc-linux-gnu > (PPC can be built for 32- and 64-bit) > And you can get MIPS from CodeSourcery. > > Toggling COMPILE_TEST with this may break someone's else allyesconfig. > > Best regards, > Krzysztof > Hi Krysztof and Guenter, Thanks for the help on how to build for all architectures. I will do this in the future. Building more drivers when compilation testing isn't worth the risk of making somebody's allyesconfig break. Thanks, Luis