From: "Franklin S Cooper Jr." <fcooper@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<nsekhar@ti.com>, <ssantosh@kernel.org>, <iivanov@mm-sol.com>,
<m-karicheri2@ti.com>, <iivanov.xz@gmail.com>,
<andy.shevchenko@gmail.com>, <jarkko.nikula@linux.intel.com>,
<hkallweit1@gmail.com>
Subject: Re: [PATCH] spi: Setup the master controller driver before setting the chipselect
Date: Fri, 16 Oct 2015 09:45:48 -0500 [thread overview]
Message-ID: <56210D9C.6090800@ti.com> (raw)
In-Reply-To: <20151016144305.GO14956@sirena.org.uk>
On 10/16/2015 09:43 AM, Mark Brown wrote:
> On Fri, Oct 16, 2015 at 09:27:50AM -0500, Franklin S Cooper Jr. wrote:
>
>> Makes sense. How about something like this?
>> SPI controllers may need to be properly setup before chip selects
>> can be used. Therefore, wait until the spi controller has a chance
>> to perform their setup procedure before trying to use the chip
>> select.
> Yes, that's a lot better - there's also the fact that if we assert chip
> select before we've got the pins in a good state we may cause the device
> to see signals that confuse it as we change.
Ok. I'll submit a rev2 with my updated commit message and incorporate
your suggestion also.
prev parent reply other threads:[~2015-10-16 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 20:51 [PATCH] spi: Setup the master controller driver before setting the chipselect Franklin S Cooper Jr
2015-10-16 10:28 ` Mark Brown
2015-10-16 14:27 ` Franklin S Cooper Jr.
2015-10-16 14:43 ` Mark Brown
2015-10-16 14:45 ` Franklin S Cooper Jr. [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56210D9C.6090800@ti.com \
--to=fcooper@ti.com \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=iivanov.xz@gmail.com \
--cc=iivanov@mm-sol.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=nsekhar@ti.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox