From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753666AbbJPOqA (ORCPT ); Fri, 16 Oct 2015 10:46:00 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:46440 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751510AbbJPOp7 (ORCPT ); Fri, 16 Oct 2015 10:45:59 -0400 From: "Franklin S Cooper Jr." To: Mark Brown CC: , , , , , , , , , Subject: Re: [PATCH] spi: Setup the master controller driver before setting the chipselect References: <1444942305-24038-1-git-send-email-fcooper@ti.com> <20151016102846.GJ14956@sirena.org.uk> <56210966.3040501@ti.com> <20151016144305.GO14956@sirena.org.uk> Message-ID: <56210D9C.6090800@ti.com> Date: Fri, 16 Oct 2015 09:45:48 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151016144305.GO14956@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2015 09:43 AM, Mark Brown wrote: > On Fri, Oct 16, 2015 at 09:27:50AM -0500, Franklin S Cooper Jr. wrote: > >> Makes sense. How about something like this? >> SPI controllers may need to be properly setup before chip selects >> can be used. Therefore, wait until the spi controller has a chance >> to perform their setup procedure before trying to use the chip >> select. > Yes, that's a lot better - there's also the fact that if we assert chip > select before we've got the pins in a good state we may cause the device > to see signals that confuse it as we change. Ok. I'll submit a rev2 with my updated commit message and incorporate your suggestion also.