From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932607AbbJPPG3 (ORCPT ); Fri, 16 Oct 2015 11:06:29 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:39419 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932375AbbJPPG1 (ORCPT ); Fri, 16 Oct 2015 11:06:27 -0400 Subject: Re: [PATCH 2/3] power: bq27xxx_battery: move irq handler to i2c section To: Sebastian Reichel References: <1445003052-31373-1-git-send-email-sre@kernel.org> <1445003052-31373-3-git-send-email-sre@kernel.org> CC: =?UTF-8?Q?Pali_Roh=c3=a1r?= , , From: "Andrew F. Davis" Message-ID: <56211270.4040002@ti.com> Date: Fri, 16 Oct 2015 10:06:24 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1445003052-31373-3-git-send-email-sre@kernel.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2015 08:44 AM, Sebastian Reichel wrote: > The IRQ handler is not used by the platform based > code resulting in a 'defined but not used' warning, > if CONFIG_BQ27XXX_I2C is not enabled. > > Signed-off-by: Sebastian Reichel > --- > drivers/power/bq27xxx_battery.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c > index 69e6b371a51c..880233ce9343 100644 > --- a/drivers/power/bq27xxx_battery.c > +++ b/drivers/power/bq27xxx_battery.c > @@ -762,15 +762,6 @@ static void bq27xxx_battery_update(struct bq27xxx_device_info *di) > di->last_update = jiffies; > } > > -static irqreturn_t bq27xxx_battery_irq_handler_thread(int irq, void *data) > -{ > - struct bq27xxx_device_info *di = data; > - > - bq27xxx_battery_update(di); > - > - return IRQ_HANDLED; > -} > - > static void bq27xxx_battery_poll(struct work_struct *work) > { > struct bq27xxx_device_info *di = > @@ -1061,6 +1052,15 @@ static void bq27xxx_powersupply_unregister(struct bq27xxx_device_info *di) > static DEFINE_IDR(battery_id); > static DEFINE_MUTEX(battery_mutex); > > +static irqreturn_t bq27xxx_battery_irq_handler_thread(int irq, void *data) > +{ > + struct bq27xxx_device_info *di = data; > + > + bq27xxx_battery_update(di); > + > + return IRQ_HANDLED; > +} > + > static int bq27xxx_battery_i2c_read(struct bq27xxx_device_info *di, u8 reg, > bool single) > { > Acked-by: Andrew F. Davis -- Andrew F. Davis