From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753813AbbJPQQ6 (ORCPT ); Fri, 16 Oct 2015 12:16:58 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:48120 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932416AbbJPQQu (ORCPT ); Fri, 16 Oct 2015 12:16:50 -0400 Subject: Re: [PATCH] pinctrl: tegra-xusb: Correct lane mux options To: Jon Hunter , Thierry Reding References: <1444987441-25176-1-git-send-email-jonathanh@nvidia.com> Cc: Linus Walleij , Alexandre Courbot , linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org From: Stephen Warren Message-ID: <56212308.7050405@wwwdotorg.org> Date: Fri, 16 Oct 2015 10:17:12 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1444987441-25176-1-git-send-email-jonathanh@nvidia.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2015 03:24 AM, Jon Hunter wrote: > The description of the XUSB_PADCTL_USB3_PAD_MUX_0 register in the Tegra124 > documentation implies that all functions (pcie, usb3 and sata) can be > muxed onto to all lanes (pcie lanes 0-4 and sata lane 0). However, it has > been confirmed that this is not the case and the mux'ing options much more > limited. Unfortunately, the public documentation has not been updated to > reflect this and so detail the actual mux'ing options here by function: FWIW, there's better documentation of this in the Tegra210 TRM, although the options have been expanded on that chip, so the docs don't entirely apply to Tegra124. > Function: Lanes: > pcie1 x2: pcie3, pcie4 > pcie1 x4: pcie1, pcie2, pcie3, pcie4 > pcie2 x1 (option1): pcie0 > pcie2 x1 (option2): pcie2 > usb3 port 0: pcie0 > usb3 port 1 (option 1): pcie1 > usb3 port 1 (option 2): sata0 > sata: sata0 I think this change needs a DT binding change to go along with it. Can you take a look at: http://www.spinics.net/lists/arm-kernel/msg449647.html [PATCH 1/2] dt: update Tegra XUSB padctl binding for Tegra210 (Sorry, I didn't realize anyone other than Thierry and Andrew were working on XUSB/padctl so didn't explicitly CC you on that.) ... to see what would need to be changed there? Or from a binding perspective should we simply assume that people will refer to the HW docs (or other information sources) for the exact list of available options?