From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932684AbbJPQrb (ORCPT ); Fri, 16 Oct 2015 12:47:31 -0400 Received: from mail-by2on0058.outbound.protection.outlook.com ([207.46.100.58]:23968 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932569AbbJPQr3 (ORCPT ); Fri, 16 Oct 2015 12:47:29 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@caviumnetworks.com; Message-ID: <56212A09.5080206@caviumnetworks.com> Date: Fri, 16 Oct 2015 09:47:05 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Andrew Lunn , Dinh Nguyen , Florian Fainelli CC: "David S. Miller" , , , "linux-kernel@vger.kernel.org" Subject: Re: SoCFPGA ethernet broken References: <562005AD.8020903@opensource.altera.com> <56200BD7.8020505@gmail.com> <56200E15.9080603@caviumnetworks.com> <56201158.8040806@opensource.altera.com> <56201AE7.2020103@gmail.com> <20151016033143.GA28207@lunn.ch> <20151016150345.GI10146@lunn.ch> <20151016155644.GJ10146@lunn.ch> In-Reply-To: <20151016155644.GJ10146@lunn.ch> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: SN1PR0701CA0035.namprd07.prod.outlook.com (25.162.96.45) To DM3PR07MB2138.namprd07.prod.outlook.com (25.164.4.144) X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2138;2:AQKJKFwCZPlPlgAhwYX+u5P8WrliuZd6Vu0yjAPo/2iovCtk977T2JYgiaDariiiGpMlSGvVYPs+lBU9O69wjBBonWBKqD4NxFEN4qTU5QE2R7xmWl7qoy++15uA7DxdAiFRzkA2R6KfyzflrYlbJDaTQQTdUfbyk5BpyyJ5CxE=;3:yb6wFRSsFFJYQpDm1lZcoLXvAH56wbLWaFAehhJVRvShQ9eAa2euTCNNSe5KdKfUlcN2Qg8Ek+vCHgD14WT/2Nanw2THtgWhO8gEkIYoLvuiEm+IGIYsQmZ4Vwb057NHY7md/5CZZnDNl6ce38waJA==;25:sbRydhvOeZlQ+ZBGVnhdEuvlmIg/yhkC9H90JGPXseUVmw4zQ7eNZZtRbDAyJh6exW8blasDjBGUhjXx7GRJP4yAajMwNMWdliUSsrzDzfb3AA5XZxsikfU2jjI66bwdNBZeof4MfMsIEOczvx1bvr7wXeuhjoHK2vtZgO7OLHHh3p/aKK11KOzIqxD98QagZwonBjhIA55/RFgBsL16itaW9XO2AqiRo+lE2UEpS4vhl+r7cVj/8CVWw4pZ5FSGZvPL4ANT9S4/LD7tItlIzA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2138; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2138;20:GYJAsig7foquRtpC5oEEjxkg78zDVdv4OYrC2Unzmef6QcXjY/KCvsjoBWPKX4wGOwi9277jZe/N9ALnB/PD/8wIUl2PGdTYAPsgzrTh29ueJeP0OFGBLmKBcAkrgfVj70ytKCkx46bZ8afDpck8aYZ4XNME9rLFw47tbrIZQZjJmdwXVYA0bTqt7QpOwgMPFWUZHh2fkprw7+ByFLCMtrCHbTEzja3cfhYr26vkTmO1lkExlxxALM0yQeW++OdU/4w2aleD9Phe52GJXVBI3imdfvi6hm+2kd2TPYriz/ZCRzwiSGv/yVe8mFFH5UEA4xDY1JijnvwKUU7I5C6pcs3zuY7T4DLxcAstqKM6TgV0R+EKtWdjZDnle5hRDJqBsWDdUpzEDfkSObc12uHsI0p7WJtFPMh0U0dfPuy/m2nLJ3d48YdxP45msELjrDTtqpSCV7xTTu2fF3v1lP9fNxi3QDLkf2PBYoqxVuweiYo3v3w42UVZKU2HccAbqEZXYu7K6ghXjYod6jP+EP3Lrj58vmBgiN/ga9nk9oKotkCWOHf6kLEl9G2tGIIO/l9gIo9SsJnbAEKmU2yK4jWAjfV9IA43PLzrl8NYig2oqGU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001);SRVR:DM3PR07MB2138;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2138; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2138;4:gQFbaisYSeDp60YlsfCdBeSjsJQ5gg4ZlZpLFOi9ZvDJ/hY7pKA0EGZtcgOjCU31EUdQxhjS99CjX3LVUpOLmtRasmjIxJKAgM/MBWuoLW4L5lsFgxT7f93pBi+G8i2/JUaJhWa8apGm/6nYaAIxPLlVVhiFGwKR2XoTbDcMC+GZSxyQgJs+EUQw8DXi9C08KZZtRvA1y+ovehEnOLyVO4uxiyWEa4xGj7Gd/ye7fZit6NNl2qhfIrWV9B2MBwAEXm+K2dE2/8LxnQtWBS2CM71rY80Zi40fa02Tmms0P4g15FSDLwhxObY0D7yM6NIJtiILViCJ7yfgxuoF+Zd3nS3boFn4gE5boC5al96BC2A= X-Forefront-PRVS: 0731AA2DE6 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(479174004)(24454002)(189002)(377454003)(199003)(106356001)(46102003)(69596002)(105586002)(99136001)(50986999)(76176999)(92566002)(2950100001)(81156007)(87976001)(33656002)(65956001)(50466002)(65816999)(83506001)(42186005)(87266999)(66066001)(122386002)(97736004)(101416001)(23756003)(64126003)(5001920100001)(65806001)(40100003)(5001770100001)(5004730100002)(189998001)(36756003)(5890100001)(93886004)(19580405001)(5007970100001)(47776003)(5008740100001)(19580395003)(54356999)(5001960100002)(64706001)(77096005)(59896002)(80316001)(4001350100001)(53416004);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR07MB2138;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;DM3PR07MB2138;23:n5QlJsR9uv/bIQICXGonCjbmXJICARN0L1SI6lS?= =?iso-8859-1?Q?+0CUajAHbe6eaN2H/ys7pq5srNR0yOIyqEiQbl9/YKLRKSlPJQ8qy+Z2VS?= =?iso-8859-1?Q?gAUMW6t7BKJTjBTKbhyu/ttWLGHIryIUo59sLRnmWuSF5j0qkpsLlw0vap?= =?iso-8859-1?Q?GpUPseBv14l19TkTFz2VK5AKmYVhLWNz6PGJEpZB+S9DqSHO+gHqQPvM5S?= =?iso-8859-1?Q?79q7N6QlhnrAGByDHopOKCkV0lkNLR2W0RTs0y5nAWLFsNT22YpBM1to2x?= =?iso-8859-1?Q?nN39aJcG2QgTxeq95UQtpd/OP+q0784GLABCX38u6NTn6MmTRGgfQhYt+2?= =?iso-8859-1?Q?HIWYfvA2FjE7CA/yf0xKBuUZh3xVs9A9708SCHPh2hc3+dQ/9omD3CsqEK?= =?iso-8859-1?Q?CrGAmOXdVk9VBFTZXBDdyTqJd4jvAka3Rp1fR67+w05YA89mK897NUoqQF?= =?iso-8859-1?Q?MiWTCEKU6WFceRhwq34mjA/173lrlfS40QVyVRelq6St7tXHKif2QNbvIz?= =?iso-8859-1?Q?BB8zd/6atn87zgqs/iznuWo4yHCDuAtKKinOSVCn1w0myOUmdAlgk3UTBu?= =?iso-8859-1?Q?WXU6TLRyZAhUJe49dLIenl9o/s+jOy4T/t7ZusoUZ5HvCvOH7LDPnVoYTz?= =?iso-8859-1?Q?vFzhggA0pQaFtxwWIu+cwvsCfSOg90Rgv15+YldULhuDpB1anmLPo8XQbE?= =?iso-8859-1?Q?eWKgNrSKAlcTmSljfwm6yc1+YVIUblyk3yIyuP4MNNz0/pX1jKJPsnnKZE?= =?iso-8859-1?Q?9jlTEDT5IJ5zbaMFV5MJ6dN1Ds9olleEqzbnFIZWEcsq9OV4WQQBTcxBBn?= =?iso-8859-1?Q?XRFQTqQv5RmrYAahjwZvrywjpNCWxiVuuc5fLHqS2eHiBhv9lhRKdiFjnu?= =?iso-8859-1?Q?+/ErASKihB/PqYe3NN74x2xf9mho9HwjMrBLmcCK23Hh/BF8Dn4L+oFcB2?= =?iso-8859-1?Q?l0nkRjV7uTgpdUx8A3ceIQtcTK+h6CUEHubCm3em/hFHdQit1uMWCgd6PM?= =?iso-8859-1?Q?SnXQUi1SjxoP2r2vUZKfMJAhAt396AB/hj6Q9139CYekNn+CbunDCXa0Qq?= =?iso-8859-1?Q?sJ68CJQrodBMTnvsUej/MKtzRD/HU5/iQGEFz4JDQfgDS84BvO9ezYgMqP?= =?iso-8859-1?Q?iIIwR7cPC1h9CVBtL560vqOrgPbi0n2XgYDXM4W/kqduvWG1VXmsTZZv21?= =?iso-8859-1?Q?8Jiz4GAv+oqYy3LsHyfedVyToVxs13LkPIZr39mfKdJBaiWWBWRJRhC1RK?= =?iso-8859-1?Q?u6XwKA45iagRb1atSJxnhFY7I9uG+HYJqonztQyk0wi2/LIiu7lbXI3uBF?= =?iso-8859-1?Q?CVuf5+ZM4uj2ciQ6ajbSM0DpbJJ2nSadOxr8CZ7F0hZTZzW43mHTAfi+na?= =?iso-8859-1?Q?ekMC3FeDdFSjKYXxQyKy2pmxqE2yd8ZJ4zF1e//0qdjZt27dAECCBPg0Rk?= =?iso-8859-1?Q?dkmvHmcc/MotRE=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2138;5:MLZUVE8IZ9SIwrhEutBx7iH/Hf0caos8TVRsYl0sNQgHuaFua2AeneGyrSxnYpDX/vYHme8RLiWzZKqWLLX6KYvOaYbhKKJPM8dvisxCUOxfPXgOQNzkmIJa0zYzvAKPbyNFExvJyreuju238YkKYw==;24:2rfVSarUuMhNCOac7Ryc4SPQwVn3EbFcLVi1ifKv7qFE2nSbnB/v8LSdtNRTIcrYlaBVzw3AviN+d5EPAdsqVBdhvdnwIVfAgHUmwV0MvCQ=;20:Py/qiFn7SO72A8nAahWYEEQBTCcF3dPh37EVXS30M/lTZlum0vLiowrXq0DmV1CZrFOfdkYYHphA8o5E5Tce9A== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2015 16:47:25.6614 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR07MB2138 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2015 08:56 AM, Andrew Lunn wrote: >> So I think I'll move to inspect what Florian had suggested, and that was to look >> at: drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c::stmmac_mdio_register > > I have a suspicion. If you look at the phy driver it does: > > static int ksz9021_config_init(struct phy_device *phydev) > { > const struct device *dev = &phydev->dev; > const struct device_node *of_node = dev->of_node; > > if (!of_node && dev->parent->of_node) > of_node = dev->parent->of_node; > Maybe we need to walk up the hierarchy. Perhaps something like: const struct device *dev_walker; dev_walker = &phydev->dev; do { of_node = dev_walker->of_node; dev_walker = dev_walker->parent; } while (!of_node && dev_walker); An alternative would be to assign the bus the same of_node as the bus parent. If either approach works, you can add: Acked-by: David Daney to the patch that implements it. > > In your case, you don't have a phy node in your device tree, so of_node > is NULL. So it looks in the parent device. > > phylib: Make PHYs children of their MDIO bus, not the bus' parent. > > changed what the parent is. It is now the mdio device. Before, i > suspect it was the MAC. Hence it found your properties in the MAC > node. > > What i think you might want to do is change this code. Rather than > look a dev->parent->of_node; you might want > phydev->attached_dev->dev->of_node. > > This assumes the phy has been attached to the MAC. I've no idea of the > ordering, so maybe it has not been attached yet? > > dp83867.c has similar code. However quick grep did not find any > mainline users with properties in the MAC node. If that is true, i > would suggest removing the code looking in the parent for that phy > driver. > > Andrew >