From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932766AbbJPUY2 (ORCPT ); Fri, 16 Oct 2015 16:24:28 -0400 Received: from mail-bn1on0092.outbound.protection.outlook.com ([157.56.110.92]:20384 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753150AbbJPUYZ (ORCPT ); Fri, 16 Oct 2015 16:24:25 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@caviumnetworks.com; Message-ID: <56215CF0.6080905@caviumnetworks.com> Date: Fri, 16 Oct 2015 13:24:16 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Andrew Lunn CC: Dinh Nguyen , Florian Fainelli , "David S. Miller" , , , "linux-kernel@vger.kernel.org" Subject: Re: SoCFPGA ethernet broken References: <56201158.8040806@opensource.altera.com> <56201AE7.2020103@gmail.com> <20151016033143.GA28207@lunn.ch> <20151016150345.GI10146@lunn.ch> <20151016155644.GJ10146@lunn.ch> <56212A09.5080206@caviumnetworks.com> <20151016193854.GC28207@lunn.ch> In-Reply-To: <20151016193854.GC28207@lunn.ch> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: DM2PR07CA0045.namprd07.prod.outlook.com (10.141.52.173) To BN4PR07MB2130.namprd07.prod.outlook.com (25.164.63.12) X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2130;2:7llr/hM5xazKzLGkvssf6rDWQuqdH0gZq55DKlcxICtz38BWjG/D+WVMh8washEo7IUVENf9WvFX7mrIZmOjBZhdbIMEpg2l2lg3LfSPCzdrWHhHOiQGlyX+z3mia5Yb3cWE2K5hKWU3q2jlz2fZBvnd4Sf/TAIQUeNQY7vm3Ok=;3:w9EBwUyqJDhFQVo8stgiX5ZLToYQpd5XnH6X43lBh9xFmb3x72RqgVg1vTguPfaDUHITYRq0cSnqmaI6jT8XlZB+FK6g8vfOWdFXv44L2ty5swRFV9cMRjcGbxuU0b7e9Eseh5r5HHLnA0k7Sb9HRw==;25:hkW360CThyd72RQOI3kTjmJiXqo1WAYnqrQaY0sA4nicLg1dw+0JcGibCZNoo08SUcHmF3r2dQkC45yjhval+TP3ub4PhRX8VXQSA8hEFOLRTOZrpwUjpGLmx043UCkzfVT6SHisyI3y/tKE62lqbLBsTfLmcC9uFRhETZr94j9NGT4lD8zEQFNh17Wrw8KIujaffJRDYUxfNqgbqbcVr8ihWwjvkwMaDUrxlCnbiVvlWWTKvstN5lHWr2j1orO+L/RxMdJ6HTX6X0zzolw3gA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2130; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2130;20:6M6uzAa+MTj87DA+jAO5zlSCUwskvg/EZwvp6M/PHnCcoFv87aWjuZiZ7NZWEvVqOC+sGObg98g+v2EKl5wqdrcMlyzwwUPF2udxZV1sKr5bC/oIknxLLN/2YDEknq2T10FNVwMEqhjP24jpqr2nlC1xa74YqP1dFuis7sYnV8i19O6pxZSBIRDoPa5juRphjT5jrdIKhgyO5RSFA57a5gf9cDOzo4+xttF5woUKneQHSxzNgreWIWcwfmaEQGZX3dpaNfMaSeLJqPMV+8JbV6mnaoGIz+ZSwGfO99D5No8UITxPLwIh94uG7Z7QWAAvtJ2BShOLTjg6QCTKjDlCp1I9azetg+kontKoDm+jgHL+hEJA8u+STMM4gvPIw6F03HmEUo02mQDj/yfcVxEIsOv6IUI0fAj4ybjvjUcb8/xrzoXP9ZG44hbSHNkKocoLGEVWos14/FEJJfeZvqprEU87hiakOP6i495+s3JI1RqMg6qZ0rD5zAGrYfE21Pk/pV2rnIMk623iKDbMxOlptCVDVGbXaS8IsG/LltjKLHZxNk8lUuky8We8ikKQKv2s2pKOvkwbtAqVs3ObQrg0ZhZBnQF8ODgcukLdRA/ZF08= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001);SRVR:BN4PR07MB2130;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2130; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2130;4:isGrcWmgJm9fFrXFUkG7m3oBe1iW/Jyvhtgh1wzmU8X6wRZ/lEaWSL7oPN07bKW7hu2E6jRuUUp/EgIx24vlE909UiXW0KWj0fGASW71PgyFgphJ8hoxFAtDYAvEh2NQQkCpbghttVnjIH7vVCHui6oNXNvqFw3/hOj8zp7GY+qZa7Pl+LAHWfnRhmqd76lPmZvA3G8OkSEiUwe1PipFBAck322OXCBqE1s+lQ+8clSVbXtPLulQVpnf/hxWvQ/+TWyZl0E9YRiIjWAGibrAVyQZrobmCqCqSL0q6wv+RQXnxsa5SyxGJ9tipW4HRsUHzT3PZ8WSkkV8QGztrkOKVmj+C3n0DHLz/8sg2WPUuAQ= X-Forefront-PRVS: 0731AA2DE6 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(189002)(377454003)(479174004)(199003)(5007970100001)(97736004)(77096005)(106356001)(105586002)(110136002)(76176999)(46102003)(2950100001)(80316001)(54356999)(81156007)(4001350100001)(59896002)(53416004)(65816999)(83506001)(50986999)(69596002)(101416001)(87266999)(5004730100002)(87976001)(99136001)(5008740100001)(5890100001)(33656002)(189998001)(42186005)(65956001)(93886004)(36756003)(50466002)(65806001)(92566002)(23756003)(66066001)(5001960100002)(64126003)(64706001)(122386002)(40100003)(47776003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2130;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;BN4PR07MB2130;23:LhLU8qCsRGt/3iio3DsGNVauGfxNNnVqepGnaeh?= =?iso-8859-1?Q?HMTQ+UJvmgJMiJrA65EQeMa8zSd/26Jn27pPg2cy43XZgalL9pbS0vtGc0?= =?iso-8859-1?Q?tB34vSurilF5+7JPZ0OjKZe+7Cq9IfiEaH1bnxW+jlSN3HCNiymlkPNxlP?= =?iso-8859-1?Q?CHu3WFhqE8946KPnQymdx/yro4vu/MAg6Xy//VEeasQtAuAGYPweGCF5Gi?= =?iso-8859-1?Q?3s6oqoJvUc7Id9PywbfY3KzEOzlPB3R1bU+lnmJM5ElHCYa6hbzhERb7dq?= =?iso-8859-1?Q?47meZASOphmyLPPVFkCV7hpgJ4hVVQ2aQ8Ea4PCKSVMxkynvw3XsZevxuV?= =?iso-8859-1?Q?mmL1VQtcRgQZoled0nm+Fx1WIlZ5VZFVdBbmarQIOLMwMusvWy3kWTKFvE?= =?iso-8859-1?Q?hlmDVRX2K6s+D+33ZxDq1eRukH8kWZZwDS1Ic2xPrurwlP/QzYGJRWPs3S?= =?iso-8859-1?Q?1/p5DHiEABP7TBU/XUvDLyjT+RTBTuUL0jZiwiSGHo5qjVsy7C3BXDR2vO?= =?iso-8859-1?Q?2HPwErjJASFwxFTOSVbYtxLraAv2uPZ4Z1X5GhSFkP0geqgsVcsd3hfrIt?= =?iso-8859-1?Q?QJejeL3fnU3FwRhBKbcayhp+HtqRjqhUEcx2gw6c6ZBP/1aRwFQn6q2aC/?= =?iso-8859-1?Q?qxcGHIXoXq/MaHNcMlCfuGeuNl9gQ0Tm+k414nXhfSyUWnI2tTaC97gwk8?= =?iso-8859-1?Q?FITSTItk8ySS7U463iN7JOZHjllks2vZmtKvvCVlp/L7HG7wGm7yHEohj9?= =?iso-8859-1?Q?sJwLgt3S5DfWkKE3mXE58A/udWNXzX78AjnVBbvDLNNRW//qpSMiHWVd40?= =?iso-8859-1?Q?NAoI3eyL6L3v4Jdr2VFThqz1+A/1AEYeDyBPa9VN8Bs4N9uBNQ9cwK5Whh?= =?iso-8859-1?Q?boTnx1A3ph2qvq3e/KLxygIEy35YtQlaTCdm+bU2KT7l1Ty8al4p6MGy42?= =?iso-8859-1?Q?jq7E5Lca8kBka3UABl8gSCmPjwtyU1VEsqC27uDsLxWSnl+kCvZGXUO/u2?= =?iso-8859-1?Q?1fkQwNdkegS1oJnsk/8UbOShxzsP0B6UWe25h64wrvyQuzhEP7NAHQt44W?= =?iso-8859-1?Q?IcmniwCOzvCXx0wmtudfYKeW/HIcnv9A8pEF3pATkufnBHBoo0oRDfvS36?= =?iso-8859-1?Q?0BCSxlkZB9wilp/sJK6PE55y6bNC7GefGJVYeGP3O7MSMFgO7UREB3GNH0?= =?iso-8859-1?Q?rj4Mvvcp15MOrPm+XI0FeWaYd8pEA7br3TYXcedmqwy6S37h6xOMOdfeCd?= =?iso-8859-1?Q?CeT6PfJmg2RhVCZIX5s1bo22+zJhnxC/D3fWPpVJRXIYDdIPkgMbTe3xPr?= =?iso-8859-1?Q?dpa8SDNZkFDagICJFWSO0bZhPaAsOykOsOkljR/aw/R3Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2130;5:Intiz0WDw4utGDi9+Qj11NmfArOXNM+IaJDzh+4NCgq7JZIZd7WfRpKHQ4vW1rgmoP8ngWXfh3oCN/VP1ked+DwsJT33vKu059hq9cacetoS9AhoKOUlqh0irQox01MzLeYM4S0bqh8qYEdc6Bn/Vg==;24:TN9RNfcpc+3az3UaA7wc/Lnv62e9pltOgsAnxW0Z81LIHw+U1U5TUoFfXmpXnrVNZtLngCmSPJKecjFqQo2e9O2hVnZzdMIavpCNLyHOCtY=;20:5io6f6U6Gk9YpreSRE1h0W6ygpuW8R5GHP+rBuqsosPqEkR0GUme+NOdb2JIS4a2jnwJrgebmhB2SLBNhr6zQg== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2015 20:24:20.5800 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2130 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2015 12:38 PM, Andrew Lunn wrote: >>> Maybe we need to walk up the hierarchy. >>> >>> Perhaps something like: >>> >>> const struct device *dev_walker; >>> >>> dev_walker = &phydev->dev; >>> do { >>> of_node = dev_walker->of_node; >>> dev_walker = dev_walker->parent; >>> } while (!of_node && dev_walker); >>> >> >> The above code seems to have fixed the issue. > > What i don't like about this is that it allows you to put these > properties in the mdio device node. These are phy properties, not mdio > properties.... Yes, we know that the device tree is not correctly formed. You have a choice: A) Fix the device tree and any code that may have to change to work with a good device tree. B) Change the code to work with the screwy existing device tree. The above seems to work, other things may also be possible. I can't really make any decisions as to what the best way to proceed is, as I neither have the hardware in question, nor the time to work on it. David Daney > > If phydev->attached_dev->dev->of_node works, that would be my > preference. > > Andrew >